Adding support for the 'Plus' board variant of SeeedStudio XIAO nrf52840, works with Sense variants as well#5479
Draft
BryanSouza91 wants to merge 4 commits into
Draft
Conversation
BryanSouza91
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I expanded the existing xiao-ble board definition as a new board xiao-ble-plus to include the respective pins for the Plus variants.
I have my reservations about the UART definitions. The Plus variant has 2 UARTs broken out to pins. the first one is USB and UART0 pins and the second to UART1 pins. I hope the way I have defined the pins properly creates the respective UART buses.