Skip to content

uc8151: fix LUT timing calculations #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakebailey wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

uc8151: fix LUT timing calculations #884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions uc8151/uc8151.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,21 +412,26 @@ func (d *Device) Invert(invert bool) {
func (d *Device) SetLUT(speed Speed, flickerFree bool) error {
var lut LUTSet

if speed == DEFAULT {
return nil
}

// Num. of frames for single direction change.
period := 64
p := uint8(period / (2 ^ (int(speed) - 1)))
scale := 1 << (int(speed) - 1)
p := uint8(period / scale)
if p < 1 {
p = 1
}

// Num. of frames for back-and-forth change.
hperiod := period % 2
hp := uint8(hperiod / (2 ^ (int(speed) - 1)))
hperiod := period / 2
hp := uint8(hperiod / scale)
if hp < 1 {
hp = 1
}

if speed < FAST && !flickerFree {
if speed <= FAST && !flickerFree {
// For low speed everything is charge-neutral, even WB/BW.

// Phase 1: long go-inverted-color.
Expand Down