chore: move tailscale to experimental config#964
Conversation
📝 WalkthroughWalkthroughThe Tailscale configuration is moved from ChangesTailscale config relocation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@internal/bootstrap/router_bootstrap.go`:
- Around line 133-136: The error message in router_bootstrap.go still uses the
old flat config key even though the check is now in
app.config.Experimental.Tailscale.Listen. Update the fmt.Errorf text in the
tailscaleService nil guard inside the router bootstrap logic to reference the
new Experimental.Tailscale.Listen path, keeping the rest of the validation flow
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: be45e69c-0a2a-49ab-917c-f9df3a1f3b46
📒 Files selected for processing (4)
internal/bootstrap/app_bootstrap.gointernal/bootstrap/router_bootstrap.gointernal/model/config.gointernal/service/tailscale_service.go
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.env.example:
- Around line 224-239: The experimental env block in .env.example needs to be
normalized to satisfy dotenv-linter. Reorder the
TINYAUTH_EXPERIMENTAL_TAILSCALE_* entries to match the repo’s existing
convention, and update the TINYAUTH_EXPERIMENTAL_TAILSCALE_DIR default in the
experimental config section to remove the unnecessary quotes. Make the changes
within the experimental config block so the regenerated example remains
lint-clean.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 483a636d-9076-4e78-a51e-89302b8e8c7e
📒 Files selected for processing (1)
.env.example
I am having second thoughts about this integration.
Summary by CodeRabbit
New Features
Bug Fixes