Skip to content

chore: move tailscale to experimental config#964

Merged
steveiliop56 merged 4 commits into
mainfrom
chore/tailscale-exp
Jul 2, 2026
Merged

chore: move tailscale to experimental config#964
steveiliop56 merged 4 commits into
mainfrom
chore/tailscale-exp

Conversation

@steveiliop56

@steveiliop56 steveiliop56 commented Jul 2, 2026

Copy link
Copy Markdown
Member

I am having second thoughts about this integration.

Summary by CodeRabbit

  • New Features

    • Tailscale-related configuration has been reorganized under an experimental settings section, including a new default state directory and Docker-specific state path.
    • Updated the sample environment variables to match the new experimental Tailscale key names.
  • Bug Fixes

    • Tailscale listener/serving activation now depends on the experimental Tailscale enable setting.
    • Funnel behavior and URL/cookie updates now follow the experimental Tailscale configuration.

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 2, 2026
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The Tailscale configuration is moved from Config.Tailscale to Config.Experimental.Tailscale. Default initialization, Docker overrides, bootstrap/service call sites, and example environment variables now use the nested experimental config.

Changes

Tailscale config relocation

Layer / File(s) Summary
Config struct and defaults
internal/model/config.go
Config.Tailscale is replaced by Config.Experimental, ExperimentalConfig now contains Tailscale TailscaleConfig, and default/Docker initialization uses Experimental.Tailscale.Dir.
Bootstrap and service consumers updated
internal/bootstrap/app_bootstrap.go, internal/bootstrap/router_bootstrap.go, internal/service/tailscale_service.go
App URL replacement, listener selection, service startup, funnel warnings, and funnel listener selection now read Tailscale settings from Config.Experimental.Tailscale.
Example env keys updated
.env.example
The example environment file replaces the top-level Tailscale block with TINYAUTH_EXPERIMENTAL_TAILSCALE_* variables.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: scottmckendry, Rycochet

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: moving Tailscale configuration under the experimental config namespace.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/tailscale-exp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/service/tailscale_service.go 0.00% 7 Missing ⚠️
internal/model/config.go 0.00% 5 Missing ⚠️
internal/bootstrap/router_bootstrap.go 0.00% 2 Missing ⚠️
internal/bootstrap/app_bootstrap.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@internal/bootstrap/router_bootstrap.go`:
- Around line 133-136: The error message in router_bootstrap.go still uses the
old flat config key even though the check is now in
app.config.Experimental.Tailscale.Listen. Update the fmt.Errorf text in the
tailscaleService nil guard inside the router bootstrap logic to reference the
new Experimental.Tailscale.Listen path, keeping the rest of the validation flow
unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: be45e69c-0a2a-49ab-917c-f9df3a1f3b46

📥 Commits

Reviewing files that changed from the base of the PR and between c8b31c5 and eea7c65.

📒 Files selected for processing (4)
  • internal/bootstrap/app_bootstrap.go
  • internal/bootstrap/router_bootstrap.go
  • internal/model/config.go
  • internal/service/tailscale_service.go

Comment thread internal/bootstrap/router_bootstrap.go
Rycochet
Rycochet previously approved these changes Jul 2, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 2, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.env.example:
- Around line 224-239: The experimental env block in .env.example needs to be
normalized to satisfy dotenv-linter. Reorder the
TINYAUTH_EXPERIMENTAL_TAILSCALE_* entries to match the repo’s existing
convention, and update the TINYAUTH_EXPERIMENTAL_TAILSCALE_DIR default in the
experimental config section to remove the unnecessary quotes. Make the changes
within the experimental config block so the regenerated example remains
lint-clean.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 483a636d-9076-4e78-a51e-89302b8e8c7e

📥 Commits

Reviewing files that changed from the base of the PR and between 2f8dee0 and b1ae78f.

📒 Files selected for processing (1)
  • .env.example

Comment thread .env.example
@steveiliop56 steveiliop56 merged commit a3c4d6a into main Jul 2, 2026
5 checks passed
@steveiliop56 steveiliop56 deleted the chore/tailscale-exp branch July 2, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants