Add lazy collection creation from closure and enhance collection methods.#42
Merged
gustavofreze merged 15 commits intomainfrom Apr 15, 2026
Merged
Add lazy collection creation from closure and enhance collection methods.#42gustavofreze merged 15 commits intomainfrom
gustavofreze merged 15 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for creating lazy collections from a closure (enabling safe re-iteration) and adjusts pipeline/collection behavior accordingly, with expanded test coverage and repo metadata updates.
Changes:
- Introduces
Collection::createLazyFromClosure()backed byLazyPipeline::fromClosure()for re-iterable lazy sources. - Refactors
EagerPipelineto memoize materialization and allow repeated iteration when created from single-use iterables (e.g., generators). - Updates
each()to be a terminal operation returningvoid, and updates tests + adds new tests for closure/generator reiteration.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Collection.php | Adds createLazyFromClosure() and changes each() to return void. |
| src/Collectible.php | Extends public interface with createLazyFromClosure() and updates each() contract. |
| src/Internal/LazyPipeline.php | Supports closure-based sources by invoking factory per iteration. |
| src/Internal/EagerPipeline.php | Switches to staged processing with memoized materialization for reiteration. |
| src/Internal/Operations/Transforming/Rearrange.php | Minor formatting adjustment in match arm. |
| tests/LazyCollectionTest.php | Updates each() tests and adds closure-backed lazy collection tests. |
| tests/EagerCollectionTest.php | Adds generator reiteration test and updates each() usage. |
| tests/CollectionTest.php | Adds parity tests comparing closure/lazy/eager behavior and type preservation. |
| .gitattributes | Adds LF normalization, diff drivers, and updates export-ignore rules. |
| .claude/* | Adds documented rules for testing, code style, workflows, and documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.