Implement 2D Dot Product#7
Open
TimTheBig wants to merge 3 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements two-lane dot product functions (dot2_refs and active_dot2_refs) for the Real type, along with associated microbenchmarks and unit tests. The implementation includes optimized paths for rational numbers and symbolic fallbacks. Feedback focuses on issues within benchmarks.md, specifically the introduction of redundant rows for existing benchmarks, the accidental clearing of previous timing data for atanh special forms, and the inclusion of atan2 benchmark results that appear to be unrelated to the current changes.
TimTheBig
commented
May 21, 2026
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Ryan <132001783+TimTheBig@users.noreply.github.com>
TimTheBig
commented
May 21, 2026
Author
|
@timschmidt the review comments have been fixed it's good to go, do you mind having a quick look? |
|
Are any plans to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds
dot2_refs, with tests and benches