Add native module regression coverage#224
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
VM_Callmust zero-fill missingvmMainarguments before invoking native entry points, preventing nargs=0 calls from passing stack garbage.Sys_FOpen/fwritecache writes, and cache-before-looseFS_LoadLibraryordering.Test files added/updated
tests/scripts/test_native_module_regressions.sh.test_native_module_regressionsinCMakeLists.txt.tests/README.md.Why this reduces regression risk
These guards cover recent native module fixes with crash/security/loading blast radius, without requiring game data, a display server, or a GPU. They make the intended invariants explicit in CTest so future edits to VM calls or pk3 native library extraction fail deterministically.
Validation
tests/scripts/test_native_module_regressions.shcmake -S . -B build-coverage-tests -DBUILD_TESTING=ON -DBUILD_UNIT_TESTS=OFF && ctest --test-dir build-coverage-tests -R test_native_module_regressions --output-on-failure