Remove dead USE_TESS_NEEDS_ST2 / needsST2 tessellation wiring#220
Draft
cursor[bot] wants to merge 1 commit into
Draft
Remove dead USE_TESS_NEEDS_ST2 / needsST2 tessellation wiring#220cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
USE_TESS_NEEDS_ST2 was never defined in either renderer; the active path always copied lightmap/ST2 coordinates. Drop the macro, shader and tess state, DetectNeeds bookkeeping, and redundant conditionals. Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the compile-time
USE_TESS_NEEDS_ST2path and allneedsST2state that never shipped: the macro was commented out in bothtr_local.hvariants, so the preprocessor always took the unconditional branch (always emit second UV / lightmap coords).Flags / toggles removed
USE_TESS_NEEDS_ST2(commented define removed)shader_t::needsST2DetectNeeds; no remaining readers.shaderCommands_t::needsST2/tess.needsST2assignmentsBehavioral parity
./scripts/compile_engine.sh opengland./scripts/compile_engine.sh vulkan.ctest --output-on-failureinbuild-gl-Release: all 26 tests passed (smoke, renderer regression scripts, unit tests).Notes
USE_TESS_NEEDS_NORMALremains as-is (still enabled for OpenGL, disabled for Vulkan) to avoid mixing unrelated parity work into this change.