Add pk3 native library cache regression coverage#219
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_pk3_native_library_cacheto guard pk3-backed native module extraction/cache invariants insrc/qcommon/files.c.tests/README.md.Risky behavior now covered
com_nativeLibraryExtractPk3remains archived, default-on, described, and logged at startup..so/.dllinputs, caches by basename undervm/native_cache/, probes direct/vm//modules/pk3 paths in order, rejects implicit fallbacks for explicit paths, and loads cached files only after size and CRC checks.FS_LoadLibrarycontinues trying the pk3 cache before loose filesystem paths.Test files added/updated
tests/scripts/test_pk3_native_library_cache.shCMakeLists.txttests/README.mdWhy this reduces regression risk
This path has filesystem side effects, native loader behavior, CRC reuse checks, and mod-loading compatibility impact. The source-guard test is deterministic and headless-friendly while pinning the invariants most likely to regress during future loader or filesystem edits.
Validation
tests/scripts/test_pk3_native_library_cache.shcmake -S . -B build-coverage-tests -DBUILD_TESTING=ON -DBUILD_UNIT_TESTS=OFF && ctest --test-dir build-coverage-tests -R test_pk3_native_library_cache --output-on-failure