tests: guard native module loading regressions#217
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_native_module_regressionswith CTest.Risky behavior now covered
com_nativeLibraryExtractPk3remains default-on, archived, documented, and logged at startup.vm/native_cache/extraction underfs_homepath/fs_game..socache writes continue using directSys_FOpen/fwriteinstead ofFS_WriteFile, which rejects native library paths.FS_LoadLibrarytries the pk3 cache before loose filesystem paths.VM_Callzero-fills missing vmMain argument slots before invoking DLL entrypoints.Test files added/updated
tests/scripts/test_native_module_regressions.shCMakeLists.txtWhy this reduces regression risk
These checks cover recent production-only changes in native module extraction and VM argument passing, both of which affect startup/loading paths for pk3-delivered native modules and can fail only on specific packaging or low-argument native entry calls.
Validation
tests/scripts/test_native_module_regressions.shcmake -S . -B build-coverage-tests -DBUILD_TESTING=ON -DBUILD_UNIT_TESTS=OFFctest --test-dir build-coverage-tests -R test_native_module_regressions --output-on-failure