Vulkan: remove dead USE_TESS_NEEDS_* compile-time gates#211
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
The Vulkan renderer never defined USE_TESS_NEEDS_NORMAL or USE_TESS_NEEDS_ST2 in tr_local.h, so tess.needsNormal/needsST2 were absent and all guarded assignments were stripped by the preprocessor. Remove the leftover ifdef scaffolding and unused shaderCommands_t fields so the source matches the effective always-on tessellation path. OpenGL keeps its optional fast path. Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes stale compile-time feature gates (
USE_TESS_NEEDS_NORMAL,USE_TESS_NEEDS_ST2) from the Vulkan renderer. Those macros were never defined insrc/renderers/vulkan/tr_local.h, so the preprocessor already eliminatedtess.needsNormal/tess.needsST2and all related assignments; the remaining#ifdefscaffolding only obscured the fact that the tessellation path was unconditionally active.Flags removed
USE_TESS_NEEDS_NORMAL(Vulkan)#defined for Vulkan;if (tess.needsNormal)was not emitted—bodies always ran. NoshaderCommands_tfields in the Vulkan build.USE_TESS_NEEDS_ST2(Vulkan)tess.needsST2.//#define USE_TESS_NEEDS_*in Vulkantr_local.htr_local.hwhen the optional path is used.Not changed: OpenGL renderer (
src/renderers/opengl/tr_local.hand sources) still definesUSE_TESS_NEEDS_NORMALand keeps the conditional fast path where applicable.Behavioral parity
./scripts/compile_engine.sh vulkan(Release): successctestinbuild-vk-Release(26 tests includingrenderer_regression_check,test_vulkan_regression_source_guards, smoke): all passedEffective runtime behavior for Vulkan matches the pre-change build (always-on normal / second texcoord handling for the unwrapped sites).