Remove obsolete SKIP_IDPAK_CHECK build flag#202
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
The compile-time macro only wrapped commented-out FS_CheckIdPaks() after that check was removed, so both ON and OFF paths were no-ops. Drop the CMake option, script/preset/Android/CI wiring, and update docs accordingly. Restore macOS workflow env: for Homebrew paths after stripping CFLAGS. Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the stale compile-time
SKIP_IDPAK_CHECKoption and all build/CI wiring. The only C usage was a no-op:FS_CheckIdPaks()was already removed, leaving a commented call inside#ifndef SKIP_IDPAK_CHECK.Flags removed
SKIP_IDPAK_CHECK(CMakeOPTION, compile definition,compile_engine.shskip-idpak-check, presets, Android CMake args, CICFLAGS/CXXFLAGSand-Dlines)#ifndefblock was skipped. With the macro undefined, the block ran but only contained a commented-out function call—no executable behavior. Default and non-default builds were therefore identical at runtime.Behavioral parity checks performed
cmakeconfigure +cmake --build … --target qcommonagainst a fresh build tree (/tmp/idtech3-cmake-test) after removing the option—succeeds;files.ccompiles..github/workflows/build.ymlandrenderer-tier-b.ymlwith PyYAML after fixing macOS steps (restoredenv:forLIBRARY_PATH/CMAKE_PREFIX_PATHonly).Candidates not changed (low confidence / out of scope)
USE_FLUXand other rendererUSE_*CMake toggles: still gate real optional subsystems; default ON does not imply safe deletion of OFF builds.cl_*,r_*, etc.): no evidence in this pass that any are permanently fixed or “launched” in a removable sense without gameplay risk.Files touched
src/qcommon/files.c— remove dead preprocessor block inFS_InitCMakeLists.txt— dropOPTION+target_compile_definitionsscripts/compile_engine.sh,CMakePresets.json,android/app/build.gradle,.github/workflows/*.ymlBUILD.md,AGENTS.md,docs/DEVELOPMENT_SETUP.md,docs/ARM_RASPBERRY_PI.md,docs/RENDERER_CONFIDENCE.md