Skip to content

Add man_made tag to roads layer#1928

Open
rwrx wants to merge 1 commit into
tilezen:masterfrom
rwrx:man_made
Open

Add man_made tag to roads layer#1928
rwrx wants to merge 1 commit into
tilezen:masterfrom
rwrx:man_made

Conversation

@rwrx

@rwrx rwrx commented Sep 30, 2019

Copy link
Copy Markdown
Contributor

Add man_made tag to roads layer

@nvkelso

nvkelso commented Sep 30, 2019

Copy link
Copy Markdown
Member

What is your aim here?

This PR is too broad as written, is there a specific property or feature you want to add? Having an example OSM feature to focus the discussion would be useful, please.

@rwrx

rwrx commented Oct 1, 2019

Copy link
Copy Markdown
Contributor Author

We have added this to filter man_made=dyke in roads. I was thinking about adding is as is added pier and quay: https://github.com/tilezen/vector-datasource/blob/master/yaml/roads.yaml#L838 but it can have multiple highway tag values not only path. So I am not sure how to add it properly.

@rwrx

rwrx commented Oct 1, 2019

Copy link
Copy Markdown
Contributor Author

@nvkelso nvkelso added this to the v1.9.0 milestone Nov 11, 2019
@rwrx rwrx mentioned this pull request Mar 21, 2022
@nvkelso

nvkelso commented Mar 21, 2022

Copy link
Copy Markdown
Member

If it's a dyke you're after then put this into the landuse layer instead, and just for the value(s) you're interested in.

(We've moved away from adding in any random values from an OSM key and allowlisting them, too.)

@nvkelso

nvkelso commented Mar 21, 2022

Copy link
Copy Markdown
Member

Should this be closed out in favor of #1929?

@rwrx

rwrx commented Mar 23, 2022

Copy link
Copy Markdown
Contributor Author

@nvkelso we have added this because of our style similar to OpenTopoMap which also have this for roads. What should I do or change in order for this to be allowed to merge?

@nvkelso nvkelso modified the milestones: v1.9.0, v2.0.0 Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants