Grow hashtable#941
Merged
Merged
Conversation
rphmeier
reviewed
Jun 10, 2026
rphmeier
left a comment
rphmeier
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, it's pretty simple.
You will get faster performance by refactoring it to use the async I/O facilities rather than the current approach, which synchronously reads each page individually and then writes it. By a quite significant factor, maybe as much as 10x. Fine as a follow-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a mostly vibe-coded implementation of growing the bucket storage on-disk. This way, if the buckets start to run out, the database can be grown in-place rather than needing to be rebuilt from scratch.
A large part of the line count is integrations into the
fuzzandtortureframeworks.This has been empirically tested on rollups backed by NOMT storage, but most of the implementation was written by codex, so cleanup or comments about the approach are welcome!