[pull] master from apify:master - #257
Merged
Merged
Conversation
…rity alert (#3933) ## Summary Lockfile-only bump of `brace-expansion` to its patched versions in `website/yarn.lock` (high — ReDoS), within existing ranges. The root `yarn.lock` already carries the patched `^`-range copies (brace-expansion 5.0.8, axios 1.18.1); `docs/yarn.lock` and `website/versioned_docs/version-3.17/yarn.lock` only contain the already-patched 1.x line (1.1.16). ### Not addressed here (need a decision on `resolutions`) The remaining root alerts can't close via a lockfile bump because dev tooling pins vulnerable versions: - `axios` 1.16.0 and `brace-expansion` 5.0.6 — pinned **exactly** by `nx@22.7.5` (same nx-pin pattern already handled with existing resolutions). - `@hono/node-server` < 2.0.5 — the consumer requires `^1.19.9`; the only fix is `2.0.5`, a **major (1.x→2.x)** bump. - `adm-zip` < 0.6.0 — pinned to `^0.5.x` by `generative-bayesian-network` (dev fingerprint tooling); 0.6.0 is a semver-major-ish jump. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
…Links (#3925) `RequestTransform` is declared as `RequestOptions | false | undefined | null`, and `enqueueLinks` skips a request on any falsy return. That contract held when calling `enqueueLinks` directly, but not through `context.enqueueLinks`: the crawl depth wrapper used `options.transformRequestFunction?.(newRequest) ?? newRequest`, and `??` cannot distinguish "no transform provided" from "transform returned nullish". Returning `null` or `undefined` from a request handler enqueued the request anyway — only `false` worked as documented. Closes #3920
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )