Skip to content

[pull] master from apify:master #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Jun 12, 2026
+10 −2
Merged

[pull] master from apify:master #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/playwright-crawler/src/internals/enqueue-links/click-elements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ export async function clickElementsAndInterceptNavigationRequests(

// browser.off(BrowserEmittedEvents.TargetCreated, onTargetCreated);
page.off('framenavigated', onFrameNavigated);
await context.unroute('*', onInterceptedRequest);
await context.unroute('**', onInterceptedRequest);

const serializedRequests = Array.from(uniqueRequests);
return serializedRequests.map((r) => JSON.parse(r));
Expand Down Expand Up @@ -405,7 +405,15 @@ function createTargetCreatedHandler(requests: Set<string>): (popup: Page) => Pro
* @ignore
*/
function isTopFrameNavigationRequest(page: Page, req: Request): boolean {
return req.isNavigationRequest() && req.frame() === page.mainFrame();
try {
return req.isNavigationRequest() && req.frame() === page.mainFrame();
} catch {
// `req.frame()` throws when the owning frame is unavailable - e.g. the request was
// issued by a service worker, or before/after its frame existed (see #3216). Such a
// request is not a top-frame navigation, so swallow the throw and let it pass through
// instead of crashing the route handler (which would leave the route unhandled).
return false;
}
}

/**
Expand Down
Loading