SCAL-331020: Add Spotter analyst list/default actions and analystId config - #619
Open
bahetirisabh wants to merge 2 commits into
Open
SCAL-331020: Add Spotter analyst list/default actions and analystId config#619bahetirisabh wants to merge 2 commits into
bahetirisabh wants to merge 2 commits into
Conversation
…onfig
Add two Action enum members, SpotterAnalystList and SpotterDefaultAnalyst,
so hosts can control the analyst list ("Show all") and the default Spotter
analyst entry with types and autocomplete instead of raw strings. These flow
through the existing hiddenActions/disabledActions/visibleActions arrays, so
no new plumbing is required.
Add analystId to SpotterEmbedViewConfig, serialized into the iframe URL via
the new Param.AnalystId so the FE can read it off embedParams. Setting it
pins the embed to a single spotter analyst, implying no default Spotter and
no "Show all".
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
commit: |
Picks up SpotterAnalystList, SpotterDefaultAnalyst and SpotterEmbedViewConfig.analystId. Also picks up drift already on main whose commits did not regenerate the docs: preRenderConfig from thoughtspot#603, and the enum-name corrections from thoughtspot#615 (EmbedEvent.customAction -> CustomAction, EmbedEvent.DrillDown -> Drilldown, ListPageColumns.Favorite -> Favorites, AuthEvent.SUCCESS -> AuthStatus.SUCCESS, and the removal of the non-existent HostEvent.ScheduleList examples). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two additions for the Spotter Analyst experience, targeting ThoughtSpot 26.10.0.cl / SDK 1.53.0.
1. Two new
Actionenum membersThey control the analyst list ("Show all") and the default Spotter analyst entry. These flow through the existing
hiddenActions/disabledActions/visibleActionsarrays, so there is no new plumbing — the enum entries just give hosts types and autocomplete instead of raw strings.2. New
analystIdfield onSpotterEmbedViewConfigTop-level on the view config, serialized into the iframe URL via a new
Param.AnalystId = 'analystId'the same way other embed params are, so the FE can read it offembedParams.analystId.setParamIfDefinedomits it entirely when unset, so the URL is unchanged for hosts that don't use it.Note on the typedoc diff
static/typedoc/typedoc.jsonis regenerated in a separate commit. The diff is large, but ~95% of it is mechanicalidrenumbering andlineshifts caused by inserting symbols intotypes.ts.Beyond this PR's own symbols, the regeneration also picks up drift already on
mainfrom commits that did not regenerate the docs:preRenderConfigfrom SCAL-325090 Add PreRenderConfig to control iframe z-index #603EmbedEvent.customActiontoCustomAction,EmbedEvent.DrillDowntoDrilldown,ListPageColumns.FavoritetoFavorites,AuthEvent.SUCCESStoAuthStatus.SUCCESS, and removal of theHostEvent.ScheduleListexamples (that member does not exist)Verified no documented symbol is lost by the regeneration: a symbol-set diff of old vs. new is 0 removals and 4 additions (
SpotterAnalystList,SpotterDefaultAnalyst,analystId,preRenderConfig).Test plan
analystId(present when set, absent when not).it.eachtables inconversation.spec.ts.conversation.spec.ts: 75/75 passing.sage.spec.ts, not part of this branch).