Skip to content

SCAL-331020: Add Spotter analyst list/default actions and analystId config - #619

Open
bahetirisabh wants to merge 2 commits into
thoughtspot:mainfrom
bahetirisabh:SCAL-331020
Open

SCAL-331020: Add Spotter analyst list/default actions and analystId config#619
bahetirisabh wants to merge 2 commits into
thoughtspot:mainfrom
bahetirisabh:SCAL-331020

Conversation

@bahetirisabh

@bahetirisabh bahetirisabh commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Two additions for the Spotter Analyst experience, targeting ThoughtSpot 26.10.0.cl / SDK 1.53.0.

1. Two new Action enum members

SpotterAnalystList = 'spotterAnalystList',
SpotterDefaultAnalyst = 'spotterDefaultAnalyst',

They control the analyst list ("Show all") and the default Spotter analyst entry. These flow through the existing hiddenActions / disabledActions / visibleActions arrays, so there is no new plumbing — the enum entries just give hosts types and autocomplete instead of raw strings.

2. New analystId field on SpotterEmbedViewConfig

/** Pins the embed to a single spotter analyst. Implies no default Spotter and no "Show all". */
analystId?: string;

Top-level on the view config, serialized into the iframe URL via a new Param.AnalystId = 'analystId' the same way other embed params are, so the FE can read it off embedParams.analystId. setParamIfDefined omits it entirely when unset, so the URL is unchanged for hosts that don't use it.

Note on the typedoc diff

static/typedoc/typedoc.json is regenerated in a separate commit. The diff is large, but ~95% of it is mechanical id renumbering and line shifts caused by inserting symbols into types.ts.

Beyond this PR's own symbols, the regeneration also picks up drift already on main from commits that did not regenerate the docs:

Verified no documented symbol is lost by the regeneration: a symbol-set diff of old vs. new is 0 removals and 4 additions (SpotterAnalystList, SpotterDefaultAnalyst, analystId, preRenderConfig).

Test plan

  • Added URL assertions for analystId (present when set, absent when not).
  • Added both new actions to the existing hidden/disabled it.each tables in conversation.spec.ts.
  • conversation.spec.ts: 75/75 passing.
  • Full SDK suite: 1653 passed, 44/45 suites (the single failure is a stale local untracked sage.spec.ts, not part of this branch).

…onfig

Add two Action enum members, SpotterAnalystList and SpotterDefaultAnalyst,
so hosts can control the analyst list ("Show all") and the default Spotter
analyst entry with types and autocomplete instead of raw strings. These flow
through the existing hiddenActions/disabledActions/visibleActions arrays, so
no new plumbing is required.

Add analystId to SpotterEmbedViewConfig, serialized into the iframe URL via
the new Param.AnalystId so the FE can read it off embedParams. Setting it
pins the embed to a single spotter analyst, implying no default Spotter and
no "Show all".

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@bahetirisabh
bahetirisabh requested a review from a team as a code owner August 10, 2026 18:30
@pkg-pr-new

pkg-pr-new Bot commented Aug 10, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@619

commit: bd2b7be

Picks up SpotterAnalystList, SpotterDefaultAnalyst and
SpotterEmbedViewConfig.analystId.

Also picks up drift already on main whose commits did not regenerate the
docs: preRenderConfig from thoughtspot#603, and the enum-name corrections from thoughtspot#615
(EmbedEvent.customAction -> CustomAction, EmbedEvent.DrillDown -> Drilldown,
ListPageColumns.Favorite -> Favorites, AuthEvent.SUCCESS -> AuthStatus.SUCCESS,
and the removal of the non-existent HostEvent.ScheduleList examples).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant