use the new wgpu target api#45
Open
hermet wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the ThorVG example app to use the upstream “new wgpu target API” (per thorvg/thorvg#4501), aligning the WebGPU canvas setup with the latest ThorVG WgCanvas target() signature.
Changes:
- Migrate
tvg::WgCanvas::target()calls to the new WebGPU argument format ({instance, adapter, device}). - Update the WGPU target color space argument from
tvg::ColorSpace::ABGR8888Stotvg::ColorSpace::ABGR8888in the affected WebGPU paths.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/MultiCanvas.cpp | Updates the WebGPU WgCanvas::target() call to the new target API argument structure. |
| src/Example.h | Updates the WebGPU window resize path to use the new WgCanvas::target() API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hermet
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: thorvg/thorvg#4501