[Automated] Update syft CLI Options - #4587
Conversation
thomhurst
added
automated
dependencies
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe change removes the ChangesSyft API tracking
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This update removes obsolete Format option APIs so the public declarations match the generated Syft options. Consumers using those removed members may need source updates, but no current runtime or data-integrity risk remains. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review
Reviewed this automated PR from ModularPipelines.OptionsGenerator updating the syft CLI options.
Changes: Only PublicAPI.Shipped.txt, PublicAPI.Unshipped.txt, and a new Syft.Generation.json tracking manifest are touched — no .cs files.
Verification:
- Confirmed against the base commit that
SyftAttestOptions.Format/SyftConvertOptions.Formatwere already absent from the generated.csfiles, so this PR correctly catches up the PublicAPI tracking files to match existing code (removing the stale entries fromShipped.txt, adding proper*REMOVED*markers toUnshipped.txt) rather than introducing a new removal. - The dropped
Unshipped.txtline forSyftExtensions.Syftreferenced the wrong namespace (ModularPipelines.IPipelineContextinstead ofModularPipelines.Context.IPipelineContext) — a stale/duplicate entry that never matched a real symbol. Removing it is a harmless cleanup, not a regression. - No hand-edits to generated option classes (CLAUDE.md compliant — this is the generator's own output).
No issues found.
GitHub Actions
Inactive
66977c0 to
a5aa943
Compare
There was a problem hiding this comment.
Code review
Reviewed this automated PR from ModularPipelines.OptionsGenerator updating the syft CLI options.
Changes: Only PublicAPI.Shipped.txt, PublicAPI.Unshipped.txt, and Syft.Generation.json (a tracking manifest) are touched — no .cs files.
Verification:
- Confirmed against the generated
.csfiles thatSyftAttestOptions.Format/SyftConvertOptions.Formatwere already removed by PR #4443 three days ago, but that PR left the PublicAPI tracking files stale. This PR correctly catches up: dropping the two staleShipped.txtentries and adding proper*REMOVED*markers toUnshipped.txt— a fix, not a new removal. Syft.Generation.jsonmatches the schema already used by other tools (Newman, Yq) — consistent, not a novel pattern.- Diffed this head (
a5aa9431f) against the previously-reviewed commit (66977c07f): the only change is a bump togeneratorSourceSha256, reflecting that the generator itself was updated onmain(#4544, merged after the prior review) and the PR was regenerated against it. No functional change. - No hand-edits to generated option classes — CLAUDE.md compliant, this is purely the generator's own output.
No issues found.
GitHub Actions
Failure
a5aa943 to
42b4d7a
Compare
There was a problem hiding this comment.
Code review
Reviewed this automated PR from ModularPipelines.OptionsGenerator updating the syft CLI options.
Changes: Only PublicAPI.Shipped.txt, PublicAPI.Unshipped.txt, and the new Syft.Generation.json tracking manifest are touched — no .cs files.
Verification:
- Checked the generated
.csfiles at this head (SyftAttestOptions.Generated.cs,SyftConvertOptions.Generated.cs,SyftExtensions.Generated.cs): neitherFormatproperty nor the oldSyft(this IPipelineContext)extension method exist in the actual generated code. ThePublicAPI.txtchanges in this PR correctly catch the tracking files up to code that was already regenerated — removing two staleShipped.txtentries and adding matching*REMOVED*markers toUnshipped.txt— rather than introducing a new API removal. Syft.Generation.jsonfollows the same schema already used for other tools (Newman, Yq, etc.) — consistent, not a novel pattern.- Diffed this PR's content against the previously-reviewed state: functionally identical (same PublicAPI catch-up), just regenerated at a new head commit — no new behavior introduced.
- No hand-edits to generated option classes — CLAUDE.md compliant, this is purely the generator's own output.
No issues found.
42b4d7a to
3a7f3be
Compare
There was a problem hiding this comment.
Code review
Reviewed this automated PR from ModularPipelines.OptionsGenerator updating the syft CLI options.
Changes: Only PublicAPI.Shipped.txt, PublicAPI.Unshipped.txt, and the new Syft.Generation.json tracking manifest are touched — no .cs files.
Verification:
- Confirmed against the generated
.csfiles at this head (SyftAttestOptions.Generated.cs,SyftConvertOptions.Generated.cs,SyftExtensions.Generated.cs): theFormatproperty and the oldSyft(this IPipelineContext)extension method are genuinely absent from the actual generated code. ThePublicAPI.txtchanges correctly catch the tracking files up to code that was already regenerated, rather than introducing a new API removal. Syft.Generation.jsonfollows the same schema already used for other tools — consistent, not a novel pattern.- The PR content (diff against current base) is byte-for-byte identical to the previously-reviewed commit
42b4d7a1— the head SHA only changed because the branch was rebased onto a newermain; no new functional change was introduced. - No hand-edits to generated option classes — CLAUDE.md compliant, this is purely the generator's own output.
No issues found.
GitHub Actions
Inactive
3a7f3be to
b2409ff
Compare
GitHub Actions
Inactive
There was a problem hiding this comment.
Code review
This is a small, automated PR from ModularPipelines.OptionsGenerator that only touches tracking files — no hand-written or hand-tweaked generated code, consistent with the repo's rule that generated options must not be manually edited (CLAUDE.md).
Verified the change against the current generated sources rather than taking the diff at face value:
SyftAttestOptions.Format/SyftConvertOptions.Formatwere already absent fromSyftAttestOptions.Generated.cs/SyftConvertOptions.Generated.csonmain— thePublicAPI.Shipped.txt/PublicAPI.Unshipped.txtentries were stale from an earlier change. This PR correctly syncs the tracking files to match the actual generated surface.SyftExtensions.Syft(this IPipelineContext)no longer exists inSyftExtensions.Generated.csonmaineither, so removing the corresponding (never-shipped) line fromPublicAPI.Unshipped.txtis the correct way to retract an unshipped API addition (delete the line rather than marking*REMOVED*, per the Roslyn PublicAPI analyzer convention).- The new
Syft.Generation.jsontracking file follows the same schema as other tools'*.Generation.jsonfiles (e.g.Git.Generation.json), and simply backfills a previously-missing tracking file for this package.
No actionable issues found.
b2409ff to
84fcb15
Compare
GitHub Actions
Inactive
Review SummaryThis is a small, mechanical, auto-generated change with no functional/source code touched:
I cross-checked the actual generated No design, architecture, or maintainability concerns — this is a pure metadata/tracking-file catch-up commit consistent with how the Options Generator manages PublicAPI files for every other tool package. |
1 participant
Summary
This PR contains automatically generated updates to syft CLI options classes.
The generator scraped the latest CLI help output from the installed tool.
Changes
Assembly-wide public API impact
Affected API families:
Assembly/common,Syft.Breaking changes are present. Consumers may need to update method arguments, option property types or nullability, enum members, and references to removed APIs.
Representative removed or changed members:
ModularPipelines.Syft.Options.SyftAttestOptions.Format.get -> string?ModularPipelines.Syft.Options.SyftAttestOptions.Format.set -> voidModularPipelines.Syft.Options.SyftConvertOptions.Format.get -> string?ModularPipelines.Syft.Options.SyftConvertOptions.Format.set -> voidstatic ModularPipelines.Syft.Extensions.SyftExtensions.Syft(this ModularPipelines.IPipelineContext! context) -> ModularPipelines.Syft.Services.ISyft!Command coverage
Command coverage report:
Verification
🤖 Generated with ModularPipelines.OptionsGenerator