Map feature - using DIV instead of Canvas implementation - #10
Open
foreza wants to merge 7 commits into
Open
Conversation
…examples in default.js Just to get things started a bit, added all the relevant stats, classes, etc. Added placeholders for spells, proficiencies, etc. We'll need to find better places to put those but it's easier to visualize it when we have it mocked up Toned down base/maxhp since you never roll that lucky for health! Consulted: https://www.dndbeyond.com/spells https://orcpub2.com/pages/dnd/5e/character-builder https://en.wikipedia.org/wiki/Character_class_(Dungeons_%26_Dragons) http://engl393-dnd5th.wikia.com/wiki/Backgrounds Added alignments because that's always fun Removed mana since DND doesn't use mana
…n the side element Map now is drawn with 10px by 10px squares, you can set scale. Setting scale to 1 is highly not recommended, you get terrible performance (have you tried drawing 400x400 elements and see how much your computer hates you) Absolute position is calculated dynamically and then added to the map
This is temporary to help me debug / troubleshot
…ovement for characters is supported
Owner
|
@foreza Why a new PR for this? This should've gone in the previous PR for map |
Author
|
Github doesn't support it the other way, looks like the added it so you can change base |
thireven
requested changes
Aug 23, 2018
thireven
left a comment
thireven
left a comment
Owner
There was a problem hiding this comment.
Clean up the formatting of the code. There's very inconsistent line and tab spacing all over the place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic prototype, want critique before I go any further.