[SDK] Update ENS Universal Resolver address for ENSv2#8733
[SDK] Update ENS Universal Resolver address for ENSv2#87330xFirekeeper merged 2 commits intothirdweb-dev:mainfrom
Conversation
Update the hardcoded Universal Resolver address from `0xce01f8eee7E479C928F8919abD53E553a36CeF67` (old) to `0xeeeeeeee14d718c2b47d9923deab1335e144eeee` (new). The old address returns stale resolution results. This is the first step toward ENSv2 readiness — the new Universal Resolver is the canonical entry point for all ENS resolution on Ethereum Mainnet. Reference: https://docs.ens.domains/web/ensv2-readiness Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@Dhaiwat10 is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Disabled knowledge base sources:
WalkthroughUpdated the ENS Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedLatest commit: 8abb6c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hey! I'm Dhaiwat from the DevRel team at ENS Labs. We're working on getting libraries across the ecosystem ready for ENSv2.
Summary
0xce01f8eee7E479C928F8919abD53E553a36CeF67(old) to0xeeeeeeee14d718c2b47d9923deab1335e144eeee(new)Why
The old Universal Resolver returns stale/incorrect resolution results. For example, resolving
ur.integration-tests.ethreturns0x1111111111111111111111111111111111111111instead of the expected0x2222222222222222222222222222222222222222.The new address (
0xeeeeeeee14d718c2b47d9923deab1335e144eeee) is the canonical Universal Resolver for ENS on Ethereum Mainnet, already used by viem v2.35.0+ and other ENSv2-ready libraries.This is the first step toward ENSv2 readiness for the thirdweb SDK. More details: https://docs.ens.domains/web/ensv2-readiness
PR-Codex overview
This PR updates the hardcoded ENS Universal Resolver address in the
thirdwebpackage from an old address to a new one.Detailed summary
packages/thirdweb/src/extensions/ens/constants.tsfrom0xce01f8eee7E479C928F8919abD53E553a36CeF67to0xeeeeeeee14d718c2b47d9923deab1335e144eeee.Summary by CodeRabbit