audio: (cosmetic) address comments to an earlier PR#10736
Open
lyakh wants to merge 1 commit intothesofproject:mainfrom
Open
audio: (cosmetic) address comments to an earlier PR#10736lyakh wants to merge 1 commit intothesofproject:mainfrom
lyakh wants to merge 1 commit intothesofproject:mainfrom
Conversation
Address two cosmetic comments to thesofproject#10702 Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
ranj063
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Cosmetic cleanup related to earlier userspace DP/vregion work by aligning comments and header declarations with the current code, helping avoid build/compile-order issues and reducing confusion.
Changes:
- Add a forward declaration for
struct mod_alloc_ctxinaudio_buffer.hto support theallocpointer member without requiring additional includes. - Fix a stale comment in
module_adapter_dp_heap_new()to match the existing 4k lifetime allocation size.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/include/sof/audio/audio_buffer.h |
Adds forward declaration for mod_alloc_ctx used by sof_audio_buffer. |
src/audio/module_adapter/module_adapter.c |
Updates comment to match the existing vregion_create(4096, ...) behavior. |
Collaborator
Author
|
@lrudyX this one really cannot break anything... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address two cosmetic comments to #10702