vmh: limit additional buffers to non-Linux configurations#10709
Open
lyakh wants to merge 1 commit intothesofproject:mainfrom
Open
vmh: limit additional buffers to non-Linux configurations#10709lyakh wants to merge 1 commit intothesofproject:mainfrom
lyakh wants to merge 1 commit intothesofproject:mainfrom
Conversation
Commit 7f66827 ("zephyr: alloc: add 32K virtual heap bucket") unconditionally added 256k to Virtual Heap buckets. Make this conditional on a Kconfig option. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
requested review from
abonislawski,
dabekjakub,
dbaluta,
iuliana-prodan,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the extra 32KB virtual heap bucket (and corresponding virtual heap region size) configurable so Linux builds can reclaim that memory for virtual page/region bookkeeping.
Changes:
- Add a
VIRTUAL_HEAP_EXTENDEDKconfig option (defaulty) to control whether the additional VMH buffers are included. - Conditionally include the 32KB VMH bucket in
zephyr/lib/alloc.cwhenVIRTUAL_HEAP_EXTENDED=y. - Disable
VIRTUAL_HEAP_EXTENDEDin the Linux overlay, which also reduces the defaultSOF_ZEPHYR_VIRTUAL_HEAP_REGION_SIZEaccordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
zephyr/lib/alloc.c |
Wraps the 32KB VMH bucket behind CONFIG_VIRTUAL_HEAP_EXTENDED. |
zephyr/Kconfig |
Introduces VIRTUAL_HEAP_EXTENDED and makes virtual heap region size default conditional. |
app/os_linux_overlay.conf |
Disables VIRTUAL_HEAP_EXTENDED for Linux builds to free VM space for virtual regions/pages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 7f66827 ("zephyr: alloc: add 32K virtual heap bucket") unconditionally added 256k to Virtual Heap buckets. Make this conditional on a Kconfig option.