userspace: proxy: Add support for llext modules by softwarecki · Pull Request #10643 · thesofproject/sof

softwarecki · 2026-03-23T12:29:15Z

Add support for userspace llext loadable modules to the userspace proxy.
Extend the SOF_LLEXT_MODULE_MANIFEST macro with an optional variadic parameter to specify the user_mode flag for llext modules. When the argument is omitted, user_mode defaults to 0, preserving backward compatibility with existing module manifests.
Allow fast_get sram buffer sharing across multiple userspace module instances when CONFIG_SOF_USERSPACE_USE_DRIVER_HEAP is enabled.
Simplify checking whether a calling thread runs in userspace by verifying
if the K_USER flag is set.
Add a memory partition for the module driver heap k_heap structure to the module's memory domain to allow it to be referenced by syscalls.
Update the userspace_proxy_memory_init function to reflect the removal of memory double mapping in Zephyr by replacing the CONFIG_XTENSA_MMU_DOUBLE_MAP with a simple CONFIG_SOF_ZEPHYR_HEAP_CACHED check.

Copilot

Pull request overview

This PR adds support for userspace llext modules in the userspace proxy and updates related memory-domain and fast_get behavior to accommodate shared heaps and Zephyr MMU changes.

Changes:

Extend llext module manifests to optionally set a user_mode flag and propagate it into rimage manifests.
Update userspace proxy memory-domain setup (including adding a partition for the module driver heap k_heap structure) and add llext domain integration.
Adjust fast_get() behavior for userspace/driver-heap configurations and simplify userspace-thread detection.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
zephyr/lib/userspace_helper.c	Removes a now-unneeded macro alias related to heap caching configuration.
zephyr/lib/fast-get.c	Adjusts buffer sharing/caching logic and userspace-thread detection.
tools/rimage/src/manifest.c	Propagates `user_mode` into generated module manifests.
src/library_manager/lib_manager.c	Makes agent start conditional and ensures LLEXT uses no agent interface.
src/include/module/module/llext.h	Extends LLEXT manifest macro with optional `user_mode` argument.
src/audio/module_adapter/library/userspace_proxy.c	Adds llext manager integration, updates memory-domain partitioning, and handles agent-less modules.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-23T12:37:09Z

-		/* We only get there for large buffers */
-		if (k_current_get()->mem_domain_info.mem_domain->num_partitions > 1) {
+		/* We only get there for large buffers or module driver heap is in use */
+		if (k_current_get()->base.user_options & K_USER && size > FAST_GET_MAX_COPY_SIZE) {


The comment states this branch applies to 'large buffers or module driver heap is in use', but the condition only gates on size > FAST_GET_MAX_COPY_SIZE. If the driver-heap configuration is intended to share buffers across userspace instances independent of size, the condition should incorporate CONFIG_SOF_USERSPACE_USE_DRIVER_HEAP (or the comment should be corrected). As written, the driver-heap case is ignored by this userspace-thread path.

Suggested change

if (k_current_get()->base.user_options & K_USER && size > FAST_GET_MAX_COPY_SIZE) {

if ((k_current_get()->base.user_options & K_USER) &&

(size > FAST_GET_MAX_COPY_SIZE ||

IS_ENABLED(CONFIG_SOF_USERSPACE_USE_DRIVER_HEAP))) {

Can you address this, same problem, how do the comment and code relate?

lyakh · 2026-03-24T07:43:40Z

let's first merge a fast-get fix, before adding new features to it. Marking this DNM until #10639 is merged

kv2019i

Nothing major, a few notes inline.

kv2019i · 2026-03-30T11:32:54Z

-		/* We only get there for large buffers */
-		if (k_current_get()->mem_domain_info.mem_domain->num_partitions > 1) {
+		/* We only get there for large buffers or module driver heap is in use */
+		if (k_current_get()->base.user_options & K_USER && size > FAST_GET_MAX_COPY_SIZE) {


Can you address this, same problem, how do the comment and code relate?

lgirdwood · 2026-04-16T13:43:10Z

@softwarecki do I dare and click the fix conflicts button with copilot or do you want to fix ? and we can merge.

…FEST Extend the SOF_LLEXT_MODULE_MANIFEST macro with an optional variadic parameter to specify the user_mode flag for llext modules. When the argument is omitted, user_mode defaults to 0, preserving backward compatibility with existing module manifests. Update the rimage to propagate the user_mode field from the module manifest to manifest structure in the final firmware binary image. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>

Add support for userspace llext loadable modules to the userspace proxy. Call lib_manager_start_agent unconditionally, even when the system agent is not used, as this function is responsible for creating the userspace module proxy. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>

Allow fast_get sram buffer sharing across multiple userspace module instances when CONFIG_SOF_USERSPACE_USE_DRIVER_HEAP is enabled. The module driver heap is shared by all instances of a given module, so allocated buffers can safely be reused between them. Simplify checking whether a calling thread runs in userspace by verifying if the K_USER flag is set. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>

Rename user_get_partition_attr() to user_get_partition_cache_attr(). Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>

Add a memory partition for the module driver heap k_heap structure to the module's memory domain to allow it to be referenced by syscalls. When a new memory domain is created, only L2 entries mapped with OPTION_SAVE_ATTRS are copied. Memory mapped dynamically during firmware execution is not accessible in new memory domains by default. Update the code to reflect the removal of memory double mapping in Zephyr by replacing the CONFIG_XTENSA_MMU_DOUBLE_MAP with a simple CONFIG_SOF_ZEPHYR_HEAP_CACHED check. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>

Copilot AI review requested due to automatic review settings March 23, 2026 12:29

softwarecki requested review from abonislawski, dbaluta, iuliana-prodan, kv2019i, lbetlej, lgirdwood, lyakh, mmaka1 and plbossart as code owners March 23, 2026 12:29

softwarecki force-pushed the userspace-llext branch from 259de26 to 761633a Compare March 23, 2026 12:30

Copilot started reviewing on behalf of softwarecki March 23, 2026 12:35 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

softwarecki requested review from serhiy-katsyuba-intel, tmleman and wjablon1 March 23, 2026 12:52

lyakh reviewed Mar 24, 2026

View reviewed changes

Comment thread src/audio/module_adapter/library/userspace_proxy.c

Comment thread src/audio/module_adapter/library/userspace_proxy.c

Comment thread src/audio/module_adapter/library/userspace_proxy.c

lyakh added the DNM Do Not Merge tag label Mar 24, 2026

softwarecki removed the DNM Do Not Merge tag label Mar 24, 2026

lyakh reviewed Mar 25, 2026

View reviewed changes

Comment thread src/audio/module_adapter/library/userspace_proxy.c Outdated

wjablon1 reviewed Mar 25, 2026

View reviewed changes

Comment thread src/audio/module_adapter/library/userspace_proxy.c Outdated

wjablon1 reviewed Mar 25, 2026

View reviewed changes

Comment thread src/audio/module_adapter/library/userspace_proxy.c

kv2019i reviewed Mar 30, 2026

View reviewed changes

wjablon1 approved these changes Apr 15, 2026

View reviewed changes

lgirdwood approved these changes Apr 16, 2026

View reviewed changes

tmleman approved these changes Apr 16, 2026

View reviewed changes

lyakh reviewed Apr 17, 2026

View reviewed changes

Comment thread src/include/module/module/llext.h

softwarecki added 4 commits April 17, 2026 17:34

userspace: proxy: Rename user_get_partition_attr

03fb3c8

Rename user_get_partition_attr() to user_get_partition_cache_attr(). Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>

softwarecki force-pushed the userspace-llext branch from 761633a to ee44813 Compare April 17, 2026 16:18

-		if (k_current_get()->base.user_options & K_USER && size > FAST_GET_MAX_COPY_SIZE) {
+		if ((k_current_get()->base.user_options & K_USER) &&
+		    (size > FAST_GET_MAX_COPY_SIZE ||
+		     IS_ENABLED(CONFIG_SOF_USERSPACE_USE_DRIVER_HEAP))) {

Conversation

softwarecki commented Mar 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

kv2019i Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lyakh commented Mar 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kv2019i Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

lgirdwood commented Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants