✨ Add brand logo and page elements settings by b-l-i-n-d · Pull Request #2933 · themeum/tutor

b-l-i-n-d · 2026-07-29T09:48:42Z

Adds dark mode icon to icon set
Adds brand logo template with light/dark variant support
Adds brand logo upload settings field in Appearance
Adds page elements settings to control header/footer visibility per page
Replaces Spotlight Mode toggle with granular Page Elements controls, preserving existing Spotlight Mode behavior during migration to Page Elements
Removes hardcoded HTML boilerplate from templates in favor of helper functions
Supports resetting image_upload_list and toggle_matrix settings fields
Migrates the frontend course builder logo to the light brand logo setting

Linked PR: https://github.com/themeum/tutor-pro/pull/1885

…footer controls

…ements settings

…ts fields

…lity

- Replace brand-logo specific field with reusable image_upload_list - Update JS and SCSS selectors to the new generic classes

- Replace page_elements specific field with reusable toggle_matrix - Update SCSS selectors to the new generic classes

Add Template::get_site_shell_data() as the single source of truth for theme header/footer visibility and header selector, and consume it from the dashboard, account, and learning-area templates.

…e shell

…erlay offset

harunollyo · 2026-08-24T04:26:25Z


 			if ( 'imported' === $action ) {
-				if ( ! empty( $save_import_data ) ) {
+				if ( ! empty( $save_import_data['dataset'] ) ) {


why this changes?

This resolved phpstan warnings

harunollyo · 2026-08-24T04:26:33Z


 			if ( 'imported' === $action ) {
-				if ( ! empty( $save_import_data ) ) {
+				if ( ! empty( $save_import_data['dataset'] ) ) {


This resolved phpstan warnings

harunollyo · 2026-08-24T04:30:46Z

 			$multiple_select = "multiple='multiple'";
 		}

+		$classes  = '';


why this changes?

This resolved phpstan warnings

harunollyo · 2026-08-24T04:30:51Z

 			$multiple_select = "multiple='multiple'";
 		}

+		$classes  = '';


This resolved phpstan warnings

harunollyo · 2026-08-24T05:44:48Z

@@ -0,0 +1,107 @@
+<?php


file name should be - dash instead of underscore

All fields currently use underscores (_) in their naming convention; using dashes (-) would be an antipattern.

harunollyo · 2026-08-24T05:45:13Z

@@ -0,0 +1,101 @@
+<?php


same here for file name

All fields currently use underscores (_) in their naming convention; using dashes (-) would be an antipattern.

…ader and footer methods

…d course builder logo

…ction

…light fallback

…d update sidebar z-index

b-l-i-n-d added 5 commits July 29, 2026 15:46

feat(icons): add dark mode icon

a820935

feat(brand-logo): add brand logo template and frontend styles

7a3fc99

feat(brand-logo): add brand logo settings field

f0a3ff2

feat(brand-logo): add brand logo settings field

288c2cc

feat(page-elements): replace spotlight mode with page element header/…

ec78aa8

…footer controls

b-l-i-n-d changed the base branch from master to dev July 29, 2026 09:52

b-l-i-n-d added 2 commits July 29, 2026 16:42

feat(icons): replace dashicons with custom footer svg icon in page el…

39d57cf

…ements settings

refactor: remove unused CSS selectors from brand logo and page elemen…

6727240

…ts fields

b-l-i-n-d changed the title ~~✨ Add brand logo and page elements settings~~ 🧹 Remove unused CSS selectors from brand logo and page elements Jul 29, 2026

refactor: rename brand logo CSS classes from BEM to hyphenated

e7b2912

b-l-i-n-d changed the title ~~🧹 Remove unused CSS selectors from brand logo and page elements~~ 🧹 Rename brand logo CSS classes and change dashboard header/footer defaults Jul 29, 2026

fix: preserve spotlight mode behavior in page elements default visibi…

ceb3978

…lity

b-l-i-n-d changed the title ~~🧹 Rename brand logo CSS classes and change dashboard header/footer defaults~~ ✨ Add brand logo and page elements settings Jul 29, 2026

b-l-i-n-d self-assigned this Jul 29, 2026

b-l-i-n-d added the 4.0.4 label Jul 29, 2026

b-l-i-n-d added 4 commits July 29, 2026 18:43

refactor: Add show_learning_site header and footer options check

b0adfa7

refactor: Revert unintentional changes

0a17681

refactor: Update code readability

3332625

style: Update header positioning

a29d553

b-l-i-n-d marked this pull request as ready for review July 30, 2026 05:24

b-l-i-n-d requested a review from shewa12 July 30, 2026 05:24

sazedul-haque reviewed Aug 4, 2026

View reviewed changes

Comment thread views/options/field-types/brand_logo.php Outdated

Comment thread views/options/field-types/page_elements.php Outdated

b-l-i-n-d added 5 commits August 4, 2026 11:18

Merge branch 'dev' into feat/logo

798ac8b

fix(settings): resolve PHPStan type errors in Options_V2

d64abd6

refactor(settings): generic image upload list field type

11d63b5

- Replace brand-logo specific field with reusable image_upload_list - Update JS and SCSS selectors to the new generic classes

refactor(settings): generic toggle matrix field type

25965d5

- Replace page_elements specific field with reusable toggle_matrix - Update SCSS selectors to the new generic classes

refactor: Resolve pho stan warning

6e747d1

b-l-i-n-d requested a review from sazedul-haque August 4, 2026 05:50

docs: Update since tag

164455a

b-l-i-n-d removed the 4.0.4 label Aug 5, 2026

b-l-i-n-d added 3 commits August 14, 2026 12:32

feat(learning-area): track site-header overlay offset for quiz layout

2a9c87b

style(learning-area): bound quiz and summary layout to theme shell

3346fec

refactor(dashboard): move mobile nav into dashboard layout flow

c9a6487

sazedul-haque reviewed Aug 17, 2026

View reviewed changes

Comment thread assets/src/scss/frontend/dashboard/layout/_nav-mobile.scss

sazedul-haque reviewed Aug 17, 2026

View reviewed changes

Comment thread assets/src/js/v3/shared/components/Logo.tsx Outdated

b-l-i-n-d added 10 commits August 17, 2026 16:39

refactor(template): centralize site-shell data resolution

7244b23

Add Template::get_site_shell_data() as the single source of truth for theme header/footer visibility and header selector, and consume it from the dashboard, account, and learning-area templates.

feat(dashboard): apply site-shell offset controller to dashboard layouts

d28fad2

style(dashboard): offset dashboard layout beneath theme header in sit…

0d67d6a

…e shell

fix(quiz): bound quiz summary within site shell and reserve header ov…

cb4a620

…erlay offset

fix(logo): use site title as logo alt text

aebe0a2

refactor(site-shell): move site-shell controller to frontend services

9605c15

Merge branch dev into feat/logo

42fab85

style: Remove unwanted scss

b271225

feat(image-upload-list): Add description support

c3c5baf

chore: Remove unnecessary code

674e8ef

sazedul-haque approved these changes Aug 21, 2026

View reviewed changes

harunollyo requested changes Aug 24, 2026

View reviewed changes

shewa12 reviewed Aug 24, 2026

View reviewed changes

Comment thread classes/Course.php Outdated

shewa12 reviewed Aug 24, 2026

View reviewed changes

Comment thread classes/Options_V2.php

b-l-i-n-d added 7 commits August 24, 2026 13:33

fix(course): guard attachment image url retrieval for brand logo

e4d661e

refactor(template): support header and footer visibility in custom he…

de74c63

…ader and footer methods

fix(options): add fallback normalization for legacy spotlight mode an…

e5ba0ca

…d course builder logo

fix(template): add header role heading selector for theme header dete…

b225934

…ction

docs(options): update @SInCE version tag for image_upload_list

45392e1

fix(options): check both header and footer visibility for legacy spot…

4c3794c

…light fallback

feat(learning-area): move expand button under more pages container an…

ded4ede

…d update sidebar z-index

b-l-i-n-d added 4.0.7 Tutor v4.0.7 and removed 4.0.6 Tutor v4.0.6 labels Aug 25, 2026

b-l-i-n-d requested review from harunollyo and shewa12 August 25, 2026 05:50

Uh oh!

Conversation

b-l-i-n-d commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

b-l-i-n-d commented Jul 29, 2026 •

edited

Loading