Conversation
harunollyo
requested changes
Jun 2, 2026
| * @return string | ||
| */ | ||
| public static function prepare_table_name( string $table_name ) { | ||
| global $wpdb; |
Collaborator
There was a problem hiding this comment.
No need to modify this method. In multisite env WP handle the prefix.
// @see method implementation inside class-wpdb.php
public function get_blog_prefix( $blog_id = null )
Collaborator
|
WordPress Multisite, site/blog ID 1 is the main site, and its tables are stored without a numeric suffix.
|
harunollyo
requested changes
Jun 4, 2026
| public static function get_table_prefix( $table_name ) { | ||
| global $wpdb; | ||
|
|
||
| if ( is_multisite() ) { |
Collaborator
There was a problem hiding this comment.
Use and instead of nested if
| @@ -1253,11 +1254,41 @@ public static function get_last_query(){ | |||
| * | |||
| return true; | ||
| } | ||
|
|
||
| $is_base_table = strpos( $table_name, 'wp_users' ) !== false || strpos( $table_name, 'wp_usermeta' ) !== false; |
Collaborator
There was a problem hiding this comment.
Use loop based on $base_tables
harunollyo
requested changes
Jun 4, 2026
|
|
||
| if ( $wpdb->last_error ) { | ||
| error_log( $wpdb->last_error ); | ||
| $error_msg = (string) $wpdb->last_error; |
Collaborator
There was a problem hiding this comment.
this prop is string type, why we need to cast it again with another variable to log.
https://github.com/WordPress/WordPress/blob/master/wp-includes/class-wpdb.php#L84
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.