docs(adr): ADR-0042 flag remaining-consumer count on consumer removal - #332
Merged
thejefflarson merged 2 commits intoAug 8, 2026
Conversation
Process/review discipline, no engine code: when a PR removes a consumer of a shared layer or abstraction, its description states the layer's remaining live-consumer count in one line; a drop-to-one is flagged in review as a refactor smell, not merged silently. Concrete precedent recorded as Context: PR #189 added a shared model-completion cache "so EVERY model consumer is covered"; PR #190 merged eight minutes later and deleted one of its two consumers (the hypothesis stage); the conjunction — invisible to either single-PR review — left a redundant, Uncertain-pinning cache that PR #191 had to revert less than an hour later. Extends ADR-0024's single-PR redundant-by-construction rule across a two-PR conjunction. Adds a one-line CLAUDE.md Workflow checklist entry pointing at the ADR, and a docs/adr/README.md index row. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VtjoJttCvBY4dzCoE4f9vP
…layers-remaining-consumer-count-when-a
thejefflarson
deleted the
thejefflarson/jef-372-process-flag-a-shared-layers-remaining-consumer-count-when-a
branch
August 8, 2026 20:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Process/ADR change — no engine code. Records a review discipline: when a PR
removes a consumer of a shared layer or abstraction, its description states
the layer's remaining live-consumer count in one line; a drop-to-one is
flagged in review as a refactor smell, not merged silently.
The meta-finding this ADR fixes: per-PR review can't see that a neighboring
PR deleted the premise this one rests on. Concrete precedent used as the
ADR's Context (found in this repo's own history, cited by PR number, no
Linear IDs):
covered" — clean alone.
the cache's two consumers — also clean alone.
consumer, making it redundant and a live
Uncertain-pinning correctnesshazard. PR revert(model): drop the ollama completion cache — redundant + Uncertain-pinning hazard (JEF-364) #191 reverted it under an hour after refactor(engine): remove the model-backed hypothesis stage — deterministic proof only (JEF-363) #190 merged.
What changed
docs/adr/0042-flag-remaining-consumer-count-on-consumer-removal.md—new ADR recording the discipline + the perf(model): cache all ollama completions in one bounded client middleware (JEF-362) #189/refactor(engine): remove the model-backed hypothesis stage — deterministic proof only (JEF-363) #190/revert(model): drop the ollama completion cache — redundant + Uncertain-pinning hazard (JEF-364) #191 precedent as Context.
CLAUDE.md— one-line Workflow checklist entry pointing at ADR-0042.docs/adr/README.md— index row for ADR-0042.Out of scope (follow-up for the plugin owner)
The ticket also suggests the
/workarchitect step check for cross-PRpremise removal within a review batch. That's the external workflow
plugin (
~/.claude/plugins/…), not this repo — flagging here as afollow-up for whoever owns that plugin, not implementing it in this PR.
Testing
cargo test --test self_containment_guard --test file_size_guard— bothpass (confirms the new ADR carries no
JEF-nnn/linear.appreferencesand no file exceeds the 1,000-line cap).
Consequences/References), README row matches existing row format.
soundcheck:pr-review— no Critical/High findings (docs-only diff)./simplify— single-pass manual review (Agent tool unavailable in thiscontext); nothing to simplify in a 3-file docs diff.
Closes JEF-372
🤖 Generated with Claude Code