Parity: decode BMP headers from generated ExifTool tables - #15
Open
thedancingdeveloper wants to merge 1 commit into
Open
Parity: decode BMP headers from generated ExifTool tables#15thedancingdeveloper wants to merge 1 commit into
thedancingdeveloper wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BMP::MainandBMP::OS2binary tablesOracle and source
ExifTool 13.30 only:
lib/Image/ExifTool/BMP.pm:%Image::ExifTool::BMP::Mainlib/Image/ExifTool/BMP.pm:%Image::ExifTool::BMP::OS2lib/Image/ExifTool/BMP.pm:ProcessBMPt/imagesParity evidence
The full conformance classifier was run before at base
6fb64c5f246e8dde268c0597626a13ff3c2b9593and after at00f11751b545f92497d9bb60aa533c22f01434eb.Corpus totals moved from matched 5,670 / rename 11 / value difference 885 / missing 3,123 / extra 1,349 to matched 5,676 / rename 11 / value difference 884 / missing 3,118 / extra 1,344. A per-format JSON diff confirms BMP is the only changed format.
The focused incremental comparator was also run as required, but its ExifTool extractor intentionally filters the entire
Filefamily; BMP's real header tags are in that family, so it reports 0 ExifTool tags and cannot measure this slice. The conformance classifier does compare those tags and is the authoritative evidence above.Validation
CARGO_BUILD_RUSTC_WRAPPER=sccache cargo test --lib parsers::image::bmp::tests -- --nocapture: 5 passedbash scripts/verify_parity_fast.sh --skip-corpus: passedCARGO_BUILD_RUSTC_WRAPPER=sccache cargo clippy --lib -- -D warnings: passedcargo fmt --all -- --check: passedgit diff --check: passedNo AI harness, fleet, model fixer, model reviewer, or external model/API command was run.