Comment an adding HashtableConverter

[seatlemorning]

Can you please remove HastableConveter from the adapter settings, as it does solve a lot of problems, but it also causes some serious ones like #224 . That would help us to switch directly to your package.

P.S. Previously, on revision 1.2.3, the behavior of the hashtable was acceptable and we could adapt to it, but after adding the HastableConveter, we are unable to handle its behavior.

Thank you in advance! 👉👈(ಥ_ಥ)

[sancheolz]

I am trying to solve this problem without modifying the CoreRemoting code in the following way:

new BsonSerializerAdapter(new BsonSerializerConfig([
            new ObjectTypeSlotConverter(),
            new DataSetDiffGramJsonConverter(),
            new RegionInfoConverter(),
            new EncodingConverter(),
            new IPAddressConverter(),
            new IPEndPointConverter(),
            new IsoDateTimeConverter(),
            //new HashtableConverter()
        ]) { AddCommonJsonConverters = false });

The idea is to select only your own converters.
But first I get a compilation error that the ObjectTypeSlotConverter type is not public,
and secondly an exception because of trying to insert an element at a non-existent index:

System.ArgumentOutOfRangeException : Index must be within the bounds of the List. (Parameter 'index')
   at System.Collections.Generic.List`1.Insert(Int32 index, T item)
   at CoreRemoting.Serialization.Bson.BsonSerializerAdapter..ctor(BsonSerializerConfig config)

There is no working way to influence the converters collection.

[sancheolz]

This could only be done by creating my own implementation of ISerializerAdapter and copying some of the internal classes.

[yallie]

Hello!

Looks like this PR breaks because of the failing tests for the hashtable serialization.
The tests break when HashtableConverter is commented out.

[sancheolz]

@yallie graceful fix for falling tests