Drop testtools dependency#87
Closed
jelmer wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Closing: this only vendors the core protocol classes, but run.py and the filter scripts still import StreamToExtendedDecorator, TestProgram, testtools.run, etc., so dropping testtools from pyproject would break them. The testtools-free reimplementation also has test-double behaviour mismatches. Needs to be redone more completely before testtools can be dropped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... just considering what it would take to drop the dependency on testtools and make subunit a bit leaner. (won't merge without further discussion)