Skip to content

Ignore JVM array descriptors when packaging HiveMQ extensions #11928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sci-jvm-study wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Open

Ignore JVM array descriptors when packaging HiveMQ extensions #11928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ private void putSubclassesIntoJar(
for (final String subClassName : subClassNames) {
final String className = subClassName.replaceAll("/", ".");

if (!className.startsWith("[L")) {
if (!className.startsWith("[")) {
LOGGER.debug("Trying to package subclass '{}' into extension '{}'.", className, extensionId);
javaArchive.addClass(className);
} else {
Expand Down
2 changes: 2 additions & 0 deletions modules/hivemq/src/test/java/org/testcontainers/hivemq/ContainerWithExtensionSubclassIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import org.junit.jupiter.api.Timeout;
import org.slf4j.event.Level;
import org.testcontainers.hivemq.util.MyExtensionWithSubclasses;
import org.testcontainers.hivemq.util.PrimitiveArrayClass;
import org.testcontainers.hivemq.util.TestPublishModifiedUtil;
import org.testcontainers.utility.DockerImageName;
import org.testcontainers.utility.MountableFile;
Expand All @@ -21,6 +22,7 @@ void test() throws Exception {
.name("my-extension")
.version("1.0")
.mainClass(MyExtensionWithSubclasses.class)
.addAdditionalClass(PrimitiveArrayClass.class)
.build();

try (
Expand Down
12 changes: 12 additions & 0 deletions modules/hivemq/src/test/java/org/testcontainers/hivemq/util/PrimitiveArrayClass.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package org.testcontainers.hivemq.util;

/**
* Helper class that generates a primitive array descriptor ("[B")
* in the constant pool through a byte array cast.
*/
public class PrimitiveArrayClass {

public void castToByteArray(Object value) {
byte[] ignored = (byte[]) value;
}
}