Conversation
aws-lc-rs has post-quantum cryptography support, while ring does not
shuyangli
approved these changes
Apr 8, 2026
Member
shuyangli
left a comment
There was a problem hiding this comment.
seems premature but yeah doesn't hurt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aws-lc-rs has post-quantum cryptography support,
while ring does not
Note
Medium Risk
Changes the TLS crypto backend used by database connections, which can affect runtime compatibility and security behavior. It also introduces new native build dependencies (
aws-lc-sysviacmake), increasing CI/build and platform risk.Overview
Updates
sqlxto use thetls-rustls-aws-lc-rsfeature instead oftls-rustls, effectively moving Rustls fromringtoaws-lc-rsfor TLS.Cargo.lockis refreshed to add the new AWS-LC dependency chain (aws-lc-rs/aws-lc-sysplus build helpers likecmake,fs_extra,dunce,jobserver) and removeringfrom the Rustls dependency set.Reviewed by Cursor Bugbot for commit 8d23e70. Bugbot is set up for automated code reviews on this repo. Configure here.