Add scripts/ & benchmarks/ to directories checked by scripts/pylint#1047
Open
mhucka wants to merge 9 commits intotensorflow:masterfrom
Open
Add scripts/ & benchmarks/ to directories checked by scripts/pylint#1047mhucka wants to merge 9 commits intotensorflow:masterfrom
scripts/ & benchmarks/ to directories checked by scripts/pylint#1047mhucka wants to merge 9 commits intotensorflow:masterfrom
Conversation
This adds ./scripts and ./benchmarks to directories where the linter is run.
This puts the code into a function instead of running the loop at the top level of the file. This makes pylint happier.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors several utility scripts to improve code organization and linting coverage. Changes include adding docstrings to build_docs.py, wrapping the notebook formatting logic into a function in format_ipynb.py, and extending the linting script to include the benchmarks and scripts directories. A review comment suggests moving the notebook discovery logic inside the function to prevent side effects during import.
Per Gemini Code Assist, putting the assignment inside the function is better.
mhucka
changed the title
scripts/ & benchmarks/ to directories checked by scripts/pylint
mhucka
added
the
area/devops
MichaelBroughton
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
./scriptsand./benchmarksto directories where the linter is run byscripts/lint_all.sh.Additional changes in a couple of other files are part of this PR because running the linter on those files resulted in linting errors that the changes fix.