revert: remove machineUSD CLI funding - #94
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6423d441d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| address: stringArg(args, "--address"), | ||
| code: stringArg(args, "--referral-code") ?? stringArg(args, "--claim"), | ||
| network: stringArg(args, "--network") ?? stringArg(args, "-n"), | ||
| noBrowser: args.includes("--no-browser"), |
There was a problem hiding this comment.
When tempo wallet fund --network testnet (or -n testnet) is used, main() routes the command through handleCompatCommand before cli.serve, and this call now omits the parsed network. runFundingFlow consequently defaults to mainnet and polls the mainnet token balance, so testnet faucet funding is never detected and the command can wait indefinitely. Keep forwarding the network while reverting only the machineUSD-specific behavior.
Useful? React with 👍 / 👎.
| crypto: args.includes("--crypto"), | ||
| machineUsd: args.includes("--machine-usd"), | ||
| referralCode: stringArg(args, "--referral-code") ?? stringArg(args, "--claim"), |
There was a problem hiding this comment.
When a caller uses the previously supported tempo wallet fund --machine-usd, the compatibility handler still intercepts the invocation before the schema parser but now ignores this flag, causing fundAction to select the ordinary fund flow. Instead of reporting that machineUSD funding is unavailable, the CLI opens a different purchase flow and waits for the regular token balance, which can mislead callers into funding the wrong asset. Explicitly reject this withdrawn flag or allow the normal option parser to reject it.
Useful? React with 👍 / 👎.
1 participant
Why
The machineUSD CLI funding flow should not ship before its wallet and backend rollout are ready.
What