fix: clarify TransferWithMemo event description#316
Open
colee5 wants to merge 1 commit intotempoxyz:mainfrom
Open
fix: clarify TransferWithMemo event description#316colee5 wants to merge 1 commit intotempoxyz:mainfrom
TransferWithMemo event description#316colee5 wants to merge 1 commit intotempoxyz:mainfrom
Conversation
|
@colee5 is attempting to deploy a commit to the Tempo Team on Vercel. A member of the Team first needs to authorize it. |
dome
pushed a commit
to paysonow/node
that referenced
this pull request
Apr 18, 2026
Ref tempoxyz/docs#316 This PR introduces `TICK_SPACING` and enforces that new orders placed after the allegretto hardfork adhere to the specified tick spacing. Note that fill logic still iterates through each tick in the tick bitmap, and this should be updated in the future for more a efficient search over existing liquidity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous note implied developers call
transferWithMemodirectly.Looking at the SDK source in
wevm/viem(src/tempo/actions/token.ts),transferWithMemois called internally bytoken.transferwhen amemoparam is passed — developers never call it directly.Updated the note to reflect the actual developer experience.