Improve Search Attribute deletion messaging#3629
Open
laurakwhit wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
|
|
||
| {#each $formData.attributes as _, index} | ||
| {#each $formData.attributes as _, index (index)} | ||
| <SearchAttributeRow |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| {#each $formData.attributes as _, index} | ||
| {#each $formData.attributes as _, index (index)} | ||
| <SearchAttributeRow | ||
| name={$formData.attributes[index].name} |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| @@ -164,7 +207,9 @@ | |||
| submitting={$submitting} | |||
Contributor
There was a problem hiding this comment.
⚠️ Element implicitly has an 'any' type because index expression is not of type 'number'.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
isExistingprop when adding a row so button to remove row is a close icon instead of a trash icon for new attributes.getSupportedTypesprop was removed and the content component now defines the type list internally.<p>that now includes a "Search Attribute docs" Link.hideCancelButtonprop removed since it was not being used.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
For an existing search attribute
For a new search attbibute
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-4190Docs
Any docs updates needed?