Generate matching load-balancing rpc wrappers - #11877
Draft
dnr wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add logic to generate matching client load-balancing rpc and metrics wrappers in genrpcwrappers, replacing the manually-maintained versions.
The only functional change is that more of the request messages are shallow-cloned than before (the manual code used CloneProto for convenience, but generated code can shallow-clone without risking forgetting new fields).
Why?
Improve consistency and maintainability. Makes it easier to add new load-balancing rpcs.
How did you test it?