fix: only set Nexus start on_conflict_options when there's something to attach - #1799
Open
tekkaya wants to merge 1 commit into
Open
fix: only set Nexus start on_conflict_options when there's something to attach#1799tekkaya wants to merge 1 commit into
tekkaya wants to merge 1 commit into
Conversation
tekkaya
force-pushed
the
nexus-onconflict-linkless
branch
from
September 1, 2026 00:25
3fbf394 to
4abaa11
Compare
…to attach Matches sdk-go; the attach flags were previously always enabled even with no links or callbacks to attach, which the server rejects. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
tekkaya
force-pushed
the
nexus-onconflict-linkless
branch
from
September 1, 2026 00:26
4abaa11 to
54278a7
Compare
tekkaya
marked this pull request as ready for review
September 1, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
on_conflict_optionson Nexus-context workflow/activity starts is now only set when there are links or callbacks to attach, instead of unconditionally. Server rejectson_conflict_optionswhen no links or callbacks exist to attach.Why?
Matches sdk-go (and sdk-java's in-progress alignment, temporalio/sdk-java#3048) — the attach flags were previously always enabled even with nothing to attach.
Checklist
on_conflict_optionspopulation in start activity request