Add link field to propagate backlink in signal and signal-with-start responses#761
Open
long-nt-tran wants to merge 1 commit intotemporalio:masterfrom
Open
Add link field to propagate backlink in signal and signal-with-start responses#761long-nt-tran wants to merge 1 commit intotemporalio:masterfrom
long-nt-tran wants to merge 1 commit intotemporalio:masterfrom
Conversation
This was referenced Apr 9, 2026
long-nt-tran
force-pushed
the
signals-backlink-api
branch
from
7abc353 to
5c99d1b
Compare
bergundy
reviewed
Apr 10, 2026
| // Link to be associated with the WorkflowExecutionSignaled event. | ||
| // Added on the response to propagate the backlink. | ||
| temporal.api.common.v1.Link signal_link = 3; | ||
| // Workflow start link to be associated with the WorkflowExecutionStarted event. |
Member
There was a problem hiding this comment.
Would this be propagated back to the caller if the workflow was already started? Seems like that would be confusing. I would call out the behavior in the docstring.
Contributor
There was a problem hiding this comment.
IMO it should behave like the workflow event link on a normal start workflow, so link to the start if the workflow is started, link to the workflow options update if a callback was attached after the workflow was started.
Author
There was a problem hiding this comment.
commenting for posterity: chatted w/ both offline and we decided to add this in a later PR
long-nt-tran
force-pushed
the
signals-backlink-api
branch
from
5c99d1b to
168fcbb
Compare
bergundy
reviewed
Apr 10, 2026
bergundy
approved these changes
Apr 10, 2026
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Approved with a small comment.
long-nt-tran
force-pushed
the
signals-backlink-api
branch
from
168fcbb to
c7d4e90
Compare
Quinn-With-Two-Ns
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added
linkfields onSignalWorkflowExecutionResponseandSignalWithStartWorkflowExecutionRequest. I think a singular link should suffice but if reviewers feel otherwise (especially w.r.t.SignalWithStartWorkflowExecutionRequest) let me know.Why?
To propagate backlinks on signal and signal-with-start executions back to the caller.
Breaking changes
Not a breaking change (unused field)
Server PR
temporalio/temporal#9897