Skip to content

cleanup: removed chains dead code#3039

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
arvindk-softwaredev:fix/cleanup-chains
Jul 20, 2026
Merged

cleanup: removed chains dead code#3039
tekton-robot merged 1 commit into
tektoncd:mainfrom
arvindk-softwaredev:fix/cleanup-chains

Conversation

@arvindk-softwaredev

@arvindk-softwaredev arvindk-softwaredev commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Changes

Part of: #2751

Removed dead code - pkg/chain/chain.go

This in turn removed all indirect dependencies which were bloating up the CLI

Removing this dead code drops 1 direct and 75 indirect dependencies (314 → 238 total), significantly reducing the attack surface.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 17, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 17, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: arvindk-softwaredev / name: Arvind (8b67b5e)

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 17, 2026
@arvindk-softwaredev arvindk-softwaredev changed the title removed chains dead code cleanmup: removed chains dead code Jul 17, 2026
@arvindk-softwaredev arvindk-softwaredev changed the title cleanmup: removed chains dead code cleanup: removed chains dead code Jul 17, 2026
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 17, 2026
@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyansh42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2026
@divyansh42

Copy link
Copy Markdown
Member

/retest

pkg/chain/chain.go was never imported by any command or package
in the CLI. Removing this dead code drops 1 direct and 75
indirect dependencies (314 → 238 total), significantly reducing
the attack surface.

Signed-off-by: Arvind <arvkrish@redhat.com>
Assisted-by: Claude Opus 4 (via Cursor)
@pratap0007

Copy link
Copy Markdown
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2026
@tekton-robot
tekton-robot merged commit ff8a9d6 into tektoncd:main Jul 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants