cleanup: removed chains dead code#3039
Merged
tekton-robot merged 1 commit intoJul 20, 2026
Merged
Conversation
|
|
divyansh42
approved these changes
Jul 17, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyansh42 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/retest |
pkg/chain/chain.go was never imported by any command or package in the CLI. Removing this dead code drops 1 direct and 75 indirect dependencies (314 → 238 total), significantly reducing the attack surface. Signed-off-by: Arvind <arvkrish@redhat.com> Assisted-by: Claude Opus 4 (via Cursor)
arvindk-softwaredev
force-pushed
the
fix/cleanup-chains
branch
from
July 17, 2026 12:37
8b67b5e to
9b98da4
Compare
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Part of: #2751
Removed dead code -
pkg/chain/chain.goThis in turn removed all indirect dependencies which were bloating up the CLI
Removing this dead code drops 1 direct and 75 indirect dependencies (314 → 238 total), significantly reducing the attack surface.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes