Add filelock for git operations#28
Open
therazix wants to merge 1 commit into
Open
Conversation
LecrisUT
reviewed
May 21, 2026
Comment on lines
+97
to
+98
| rmtree(destination, ignore_errors=True) | ||
|
|
Member
There was a problem hiding this comment.
Looks like a no op because this is gated by destination.exists. In fact, why not just move that check inside here?
Comment on lines
94
to
95
| # Get unique path | ||
| destination = get_unique_clone_path(url) |
Member
There was a problem hiding this comment.
This looks bad. You already calculated the destination in previous steps and made it linked to a file lock. Make sure the destination in the calling function is used instead
Comment on lines
-104
to
+130
| # Fetch remote refs | ||
| _fetch_remote(common, destination, logger) | ||
| try: | ||
| # Fetch remote refs | ||
| _fetch_remote(common, destination, logger) | ||
| except GeneralError: | ||
| logger.warning("Unable to fetch remote repository. Trying to clone again.") | ||
| clone_repository(url, logger) |
Member
There was a problem hiding this comment.
Can elaborate when this can occur and why re-cloning would help? Also putting the rmtree here is more understandable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR wraps all git operations in
get_git_repositorywith a per-repositoryFileLockto prevent concurrent tasks from potentially corrupting a shared local clone. Also, if fetching from the remote fails, the repository is automatically wiped and re-cloned to ensure a clean state.