fix(sql-editor): stop splitting routine bodies on bare END

[cursor]

Summary

Audit of recent SQL editor commits (#245 safe-mode SELECT joins, #246 routine DDL one-cell, #247 grid copy) found one high-confidence critical correctness bug in #246.

Routine DDL nesting treated every unqualified END as a block closer. Bodies that used end as an alias/column/variable (AS end, SELECT end, DECLARE end INT) closed BEGIN early, so later DELETE/UPDATE lines became separate top-level cells and could run against the live DB on Run All.

Fix

• Track BEGIN / CASE / BEGIN TRY / BEGIN CATCH on a stack
• Pop BEGIN only for statement-leading END (not mid-expression identifiers)
• Close SQL Server TRY/CATCH frames on END TRY / END CATCH so following statements are not swallowed

Test plan

• npx vitest run packages/sql/src/modules/sql-splitter.test.ts (96 passed)
• New regressions: AS end / DECLARE end / END AS CASE expr / BEGIN TRY…CATCH

Audit notes (no other criticals)

• fix(sql-editor): skip Safe mode confirm for SELECT/JOIN reads #245: Multi-table confirm now write-only; isWriteStatement confirm path unchanged — no write bypass found
• feat(sql-editor): copy cell, headers, or a selected range #247: Copy selection/escaping looks correct; no silent truncation/corruption for migrate

  

---

Note

High Risk
Routine splitter bugs could split destructive DML out of procedure bodies and execute it as top-level SQL on Run All; hydrate mis-picks could emit wrong DDL on weave revert paths.

Overview
Fixes critical SQL editor splitting where routine DDL nesting treated every unqualified END as closing BEGIN. Aliases and columns named end (AS end, SELECT end, DECLARE end INT) could end the routine cell early so later DELETE/UPDATE became separate top-level cells and could run on Run All.

The splitter now tracks BEGIN / CASE / BEGIN TRY / BEGIN CATCH on a stack and only closes BEGIN on statement-leading END, not mid-expression identifiers. SQL Server END TRY / END CATCH close the matching frames. New tests cover those cases plus BEGIN TRY…CATCH batches.

Separately, pickOwnerContainer picks the owner-level container from a same-owner object group using the same ordered type:OWNER keys as blueprint assembly. hydrateTableSchemas uses it instead of the first container-typed object, so a table-owned trigger that appears before table:CUSTOMER is not mistaken for the table (wrong DDL like ALTER TABLE trg_audit vs customer). pickOwnerContainer and isLokeeContainerType are re-exported from the package entry.

^{Reviewed by Cursor Bugbot for commit 671477e. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_104530e7-9c23-4666-9deb-ddd6a34e6fa9)