Skip to content

refactor(lokee): slim table timeline inspector and revert helpers #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huyplb merged 1 commit into from
Aug 13, 2026
Merged

refactor(lokee): slim table timeline inspector and revert helpers #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 15 additions & 35 deletions apps/web/src/backend/api/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,17 +997,6 @@ export function createApiRoutes(connectionModule: ConnectionModule, connectionSt
res.json(result);
});

const publicRevertPlan = (plan: Awaited<ReturnType<LokeeWeaveStore['planRevert']>>) => {
if (!plan) return null;
return {
fromVersion: plan.fromVersion,
toVersion: plan.toVersion,
alreadyAtTarget: plan.alreadyAtTarget,
reversal: plan.reversal,
statements: plan.statements,
};
};

router.get(
'/lokee/databases/:id/revert/plan',
requirePermissions('schema.browse'),
Expand All @@ -1026,7 +1015,8 @@ export function createApiRoutes(connectionModule: ConnectionModule, connectionSt
res.status(404).json({ error: 'Version not found' });
return;
}
res.json(publicRevertPlan(plan));
const { steps: _steps, ...published } = plan;
res.json(published);
}
);

Expand Down Expand Up @@ -1058,9 +1048,9 @@ export function createApiRoutes(connectionModule: ConnectionModule, connectionSt
res.status(404).json({ error: 'Version not found' });
return;
}
const published = publicRevertPlan(plan);
if (plan.alreadyAtTarget) {
res.json({ ok: true, alreadyAtTarget: true, ...published });
const { steps, ...published } = plan;
if (plan.alreadyAtTarget || steps.length === 0) {
res.json({ ok: true, ...published, alreadyAtTarget: true });
return;
}
if (plan.reversal.risk === 'blocked') {
Expand All @@ -1081,43 +1071,33 @@ export function createApiRoutes(connectionModule: ConnectionModule, connectionSt
});
return;
}
if (plan.steps.length === 0) {
res.json({ ok: true, alreadyAtTarget: true, ...published });
return;
}

let success = false;
let executeError: string | undefined;
let failed = true;
let executeError = 'Revert failed';
try {
await migrationModule.execute(dialect, option, schema, plan.steps, (event) => {
await migrationModule.execute(dialect, option, schema, steps, (event) => {
if (event.type === 'done') {
success = event.success;
executeError = event.error;
failed = !event.success;
if (event.error) executeError = event.error;
}
});
} catch (error: unknown) {
success = false;
failed = true;
executeError = error instanceof Error ? error.message : 'Revert failed';
}
if (!success) {
res.status(500).json({
ok: false,
error: executeError ?? 'Revert failed',
...published,
});
if (failed) {
res.status(500).json({ ok: false, error: executeError, ...published });
return;
}

try {
const capture = await captureLiveSchema(userId, { dialect, option, schema }, 'revert');
res.json({ ok: true, capture, ...published });
} catch (error: unknown) {
const message = error instanceof Error ? error.message : 'capture failed';
res.status(500).json({
ok: false,
error:
error instanceof Error
? `Schema reverted but capture failed: ${error.message}`
: 'Schema reverted but capture failed',
error: `Schema reverted but capture failed: ${message}`,
...published,
});
}
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/backend/modules/lokee-weave.module.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ describe('inspectObject', () => {
const v2 = await weave.capture(USER, { ...IDENTITY, tables: [widened], source: 'migrate' });

const inspect = await weave.inspectObject(USER, v2.databaseId, v2.versionId, 'table:CUSTOMER');
expect(inspect?.headVersionId).toBe(v2.versionId);
expect(inspect?.growth.at(-1)?.versionId).toBe(v2.versionId);
expect(inspect?.columnMutations.map((c) => c.columnName).sort()).toEqual(['email', 'id', 'phone']);
const email = inspect?.columnMutations.find((c) => c.columnName === 'email');
expect(email?.events.map((e) => e.operation)).toEqual(['ADD', 'MODIFY']);
Expand Down
141 changes: 51 additions & 90 deletions apps/web/src/backend/modules/lokee-weave.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,6 @@ export interface ObjectInspectResult {
growth: ContainerGrowthPoint[];
/** Column ADD / MODIFY / DELETE across versions, when the focus is a table. */
columnMutations: ColumnMutation[];
headVersionId: string | null;
headVersionNumber: number | null;
}

export interface RevertPlanResult {
Expand Down Expand Up @@ -242,6 +240,10 @@ function toCanonical(key: string, object: VersionedObject): CanonicalObject {
};
}

function canonicalList(objects: Map<string, VersionedObject>): CanonicalObject[] {
return [...objects.entries()].map(([key, object]) => toCanonical(key, object));
}

/** `LIKE` prefix for children of one owner. `!` is the ESCAPE character. */
function likeOwnerPrefix(kind: string, owner: string): string {
const escaped = owner.replace(/!/g, '!!').replace(/%/g, '!%').replace(/_/g, '!_');
Expand Down Expand Up @@ -995,36 +997,15 @@ export class LokeeWeaveStore {

const atVersion = await this.objectsAtVersion(userId, databaseId, versionId);
const stored = new Map<string, StoredWeaveObject>();
for (const [key, object] of atVersion) {
stored.set(key, {
key,
type: object.type,
name: object.name,
hash: object.hash,
body: object.body,
sourceText: object.sourceText,
lineCount: object.lineCount,
firstSeenAt: object.firstSeenAt,
});
}
const blueprint = assembleBlueprint(objectKey, stored);
const history = await this.objectHistory(userId, databaseId, objectKey);
for (const [key, object] of atVersion) stored.set(key, { key, ...object });
const owner = objectKeyOwner(objectKey);
const growth = await this.containerGrowth(userId, databaseId, owner);
const kind = objectKeyKind(objectKey);
const columnMutations =
kind === 'table' || kind === 'mqt' || kind === 'view'
? await this.columnMutations(userId, databaseId, owner)
: [];
const versions = await this.listVersions(userId, databaseId, 1);
const head = versions[0] ?? null;
const isTable = kind === 'table' || kind === 'mqt' || kind === 'view';
return {
blueprint,
history,
growth,
columnMutations,
headVersionId: head?.id ?? null,
headVersionNumber: head?.number ?? null,
blueprint: assembleBlueprint(objectKey, stored),
history: await this.objectHistory(userId, databaseId, objectKey),
growth: await this.containerGrowth(userId, databaseId, owner),
columnMutations: isTable ? await this.columnMutations(userId, databaseId, owner) : [],
};
}

Expand All @@ -1049,23 +1030,20 @@ export class LokeeWeaveStore {
const toVersion = versions.find((v) => v.id === toVersionId);
if (!fromVersion || !toVersion) return null;

const emptyReversal = planReversal([]);
if (fromVersion.id === toVersion.id) {
return {
fromVersion,
toVersion,
alreadyAtTarget: true,
reversal: emptyReversal,
steps: [],
statements: [],
};
}
const none: RevertPlanResult = {
fromVersion,
toVersion,
alreadyAtTarget: fromVersion.id === toVersion.id,
reversal: planReversal([]),
steps: [],
statements: [],
};
if (none.alreadyAtTarget) return none;

const current = await this.objectsAtVersion(userId, databaseId, fromVersion.id);
const desired = await this.objectsAtVersion(userId, databaseId, toVersion.id);
const keys = new Set([...current.keys(), ...desired.keys()]);
const entries: Array<{ key: string; current?: CanonicalObject; target?: CanonicalObject }> = [];
for (const key of keys) {
for (const key of new Set([...current.keys(), ...desired.keys()])) {
const cur = current.get(key);
const tgt = desired.get(key);
if (cur && tgt && cur.hash === tgt.hash) continue;
Expand All @@ -1075,43 +1053,34 @@ export class LokeeWeaveStore {
target: tgt ? toCanonical(key, tgt) : undefined,
});
}
const reversal = planReversal(entries);

let resolvedDialect = dialect;
let resolvedSchema = schema;
if (!resolvedDialect) {
let dialectName = dialect;
let schemaName = schema;
if (!dialectName) {
const db = await store.get<{ dialect: string; schema: string | null }>(
'SELECT dialect, "schema" FROM lokee_databases WHERE id = ? AND user_id = ?',
[databaseId, userId]
);
resolvedDialect = db?.dialect;
if (resolvedSchema == null) resolvedSchema = db?.schema ?? undefined;
dialectName = db?.dialect;
schemaName ??= db?.schema ?? undefined;
}

let steps: MigrationStep[] = [];
let statements: string[] = [];
if (resolvedDialect) {
const currentTables = hydrateTableSchemas(
[...current.entries()].map(([key, object]) => toCanonical(key, object))
);
const targetTables = hydrateTableSchemas(
[...desired.entries()].map(([key, object]) => toCanonical(key, object))
);
const migration = await buildRevertMigration(currentTables, targetTables, resolvedDialect, {
targetSchema: resolvedSchema,
sourceSchema: resolvedSchema,
});
steps = migration.steps;
statements = migration.statements;
}
const migration = dialectName
? await buildRevertMigration(
hydrateTableSchemas(canonicalList(current)),
hydrateTableSchemas(canonicalList(desired)),
dialectName,
{ targetSchema: schemaName, sourceSchema: schemaName }
)
: { steps: [] as MigrationStep[], statements: [] as string[] };

return {
fromVersion,
toVersion,
alreadyAtTarget: false,
reversal,
steps,
statements,
reversal: planReversal(entries),
steps: migration.steps,
statements: migration.statements,
};
}

Expand All @@ -1123,15 +1092,7 @@ export class LokeeWeaveStore {
const store = await this.store();
if (!(await this.assertOwned(store, userId, databaseId))) return [];

const rows = await store.all<{
version_id: string;
version_number: number;
created_at: string;
source: CaptureSource;
operation: 'ADD' | 'MODIFY' | 'DELETE';
object_hash: string | null;
previous_hash: string | null;
}>(
const rows = await store.all<HistoryDeltaRow>(
`SELECT vo.operation, vo.object_hash, vo.previous_hash,
v.id AS version_id, v.version_number, v.created_at, v.source
FROM lokee_version_objects vo
Expand Down Expand Up @@ -1168,23 +1129,23 @@ export class LokeeWeaveStore {
const bodies = await this.loadObjectBodies(store, rows);
const byKey = new Map<string, Array<HistoryDeltaRow & { object_key: string }>>();
for (const row of rows) {
const list = byKey.get(row.object_key);
if (list) list.push(row);
else byKey.set(row.object_key, [row]);
const list = byKey.get(row.object_key) ?? [];
list.push(row);
byKey.set(row.object_key, list);
}

const out: ColumnMutation[] = [];
for (const [objectKey, group] of byKey) {
return [...byKey.entries()].flatMap(([objectKey, group]) => {
const events = historyEntriesFromRows(group, bodies);
if (events.length === 0) continue;
const fromBody = events.find((e) => typeof e.body?.name === 'string')?.body?.name;
const columnName =
typeof fromBody === 'string'
? fromBody
: objectKey.slice(objectKey.lastIndexOf('.') + 1).toLowerCase();
out.push({ objectKey, columnName, events });
}
return out;
if (events.length === 0) return [];
const named = events.find((e) => typeof e.body?.name === 'string')?.body?.name;
return [
{
objectKey,
columnName: typeof named === 'string' ? named : objectKey.slice(objectKey.lastIndexOf('.') + 1),
events,
},
];
});
}

private async loadObjectBodies(
Expand Down
Loading
Loading