-
Notifications
You must be signed in to change notification settings - Fork 0
Return all limit #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Return all limit #30
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
aa54b71
Change limit for ReturnAll to 200
baristaTam 66610c2
changelog++
baristaTam c44930a
edit comment
baristaTam 4799b71
update tests
baristaTam 6c59e81
changelog++
baristaTam 85da161
update ubuntu runner to latest
baristaTam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ BeforeAll { | |
| $secStringPassword = ConvertTo-SecureString -String $ENV:TestAPIPw -AsPlainText | ||
| $Credential = New-Object -TypeName System.Management.Automation.PSCredential -ArgumentList ($ENV:TestAPIUser, $secStringPassword) | ||
|
|
||
| [int]$TestId = 1770 #This will likely break at some point and need updating. We have tests based around this object existing in CDB. | ||
| [int]$TestId = 8777 #This will likely break at some point and need updating. We have tests based around this object existing in CDB. | ||
| } | ||
|
|
||
| Describe 'New-CDBConnection'{ | ||
|
|
@@ -33,7 +33,7 @@ Describe 'New-CDBConnection'{ | |
|
|
||
| It 'Encrypts the saved password'{ | ||
| { (Get-Content -Path $Script:SavedCredsDir | ConvertFrom-Json).password | ConvertTo-SecureString } | Should -Not -Throw | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -61,7 +61,7 @@ Describe 'Update-CDBSubclassUris'{ | |
| New-CDBConnection -Credential $Credential | ||
| } | ||
|
|
||
| InModuleScope 'UofICDB' { | ||
| InModuleScope 'UofICDB' { | ||
| It 'Does not throw'{ | ||
| {Update-CDBSubclassUris} | Should -Not -Throw | ||
| } | ||
|
|
@@ -124,7 +124,7 @@ Describe 'Get-CDBItem'{ | |
| BeforeAll { | ||
| New-CDBConnection -Credential $Credential | ||
| } | ||
|
|
||
| It 'Handles the redirect off an Id'{ | ||
| $null -eq (Get-CDBItem -id $TestId).subclass | Should -Be $True | ||
| $null -ne (Get-CDBItem -id $TestId).name | Should -Be $True | ||
|
|
@@ -175,10 +175,10 @@ Describe 'Get-CDBItem'{ | |
|
|
||
| Describe 'Get-CDBItemPermission'{ | ||
| It 'Returns permissions for a given item'{ | ||
| (Get-CDBItemPermission -id 1778).permissions | Should -Not -BeNullOrEmpty | ||
| (Get-CDBItemPermission -id 8777).permissions | Should -Not -BeNullOrEmpty | ||
| } | ||
|
|
||
| It 'Accepts pipeline input'{ | ||
| {Get-CDBItem -Id 1778 | Get-CDBItemPermission} | Should -Not -Throw | ||
| {Get-CDBItem -Id 8777 | Get-CDBItemPermission} | Should -Not -Throw | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here about |
||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have
$TestIdrather than the ID value?