Skip to content

fix: apply EXIF orientation during thumbnail generation #3521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

fix: apply EXIF orientation during thumbnail generation #3521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e9a1ba
Initial plan
Copilot Jul 8, 2026
9a0448a
fix: apply EXIF orientation during thumbnail generation with sharp .r…
Copilot Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/nestjs-backend/src/features/attachments/attachments-storage.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export class AttachmentsStorageService {
) {
const mimetype = ATTACHMENT_THUMBNAIL_DEFAULT_MIMETYPE;
const { smThumbnailPath, lgThumbnailPath } = generateTableThumbnailPath(path);
const image = sharp(imageBuffer, { failOn: 'none', unlimited: true });
const image = sharp(imageBuffer, { failOn: 'none', unlimited: true }).rotate();
let cutSmThumbnailPath: string | undefined;
let cutLgThumbnailPath: string | undefined;

Expand Down
2 changes: 1 addition & 1 deletion apps/nestjs-backend/src/features/attachments/plugins/local.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ export class LocalStorage implements StorageAdapter {
},
});
}
const resizedImage = image.resize(width, height);
const resizedImage = image.rotate().resize(width, height);
await resizedImage.toFile(resizedImagePath);
return newPath;
}
Expand Down
7 changes: 3 additions & 4 deletions apps/nestjs-backend/src/features/attachments/plugins/minio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,10 +253,9 @@ export class MinioStorage implements StorageAdapter {
writeStream.removeAllListeners();
writeStream.destroy();
}
const metaReader = sharp(sourceFilePath, { failOn: 'none', unlimited: true }).resize(
width,
height
);
const metaReader = sharp(sourceFilePath, { failOn: 'none', unlimited: true })
.rotate()
.resize(width, height);
await metaReader.toFile(resizedImagePath);
// delete source file
fse.removeSync(sourceFilePath);
Expand Down
7 changes: 3 additions & 4 deletions apps/nestjs-backend/src/features/attachments/plugins/s3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,10 +456,9 @@ export class S3Storage implements StorageAdapter {
writeStream.on('error', reject);
(stream as Readable).on('error', reject);
});
const metaReader = sharp(sourceFilePath, { failOn: 'none', unlimited: true }).resize(
width,
height
);
const metaReader = sharp(sourceFilePath, { failOn: 'none', unlimited: true })
.rotate()
.resize(width, height);
await metaReader.toFile(resizedImagePath);
fse.removeSync(sourceFilePath);
const upload = await this.uploadFileWidthPath(bucket, newPath, resizedImagePath, {
Expand Down