Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduling emails no longer fails
Invitations are sent from inside the
PUTthat stores the event, andDavisIMipPluginlet its exceptions escape into sabre. sabre's ownIMipPluginnever throws. So anything that went wrong while sending came back to the calendar client as a 500 — and the event was never written.With SMTP unreachable:
PUT /dav/calendars/tchap/default/meeting.ics → 500
Symfony\Component\Mailer\Exception\TransportException
Connection could not be established with host "ssl://localhost:465"
→ calendarobjects with that uri: 0
Same outcome for an attendee address that isn't RFC-compliant (
mailto:someone(at)example.org), which is worth noting because the attendee list comes straight from the organiser's client and nothing validates it beforenew Address(). The error body also handed the client the internal SMTP host.Both now return 201 with the event saved. The failure is logged and recorded on the event as a
SCHEDULE-STATUSthe client can surface:errorlog,SCHEDULE-STATUS 5.1, event savederrorlog,SCHEDULE-STATUS 5.3, event savedwarninglog,5.0, no mail — previously left$actionundefined and rendered a blank templatemailto:warninglogPARTSTATin a REPLYwarninglogwarninglog, invitation sent without the mapinfologThe map one is the same class of bug: rendering the location image is a network call on the PUT path, for decoration on an email.