add new lints matching some ECMA-262 editorial conventions#693
add new lints matching some ECMA-262 editorial conventions#693michaelficarra wants to merge 1 commit intomainfrom
Conversation
michaelficarra
force-pushed
the
algorithm-spelling-lints
branch
from
5813558 to
81e8fcb
Compare
|
|
||
| const ruleId = 'algorithm-spelling'; | ||
|
|
||
| // Note that these will be composed, so cannot contain backreferences |
There was a problem hiding this comment.
I mean... named backreferences are fine as long as you're running on an engine with tc39/ecma262#2721!
Probably the LLM copied this from here, but that comment predates the above spec change.
There was a problem hiding this comment.
Still a shared namespace. I think the comment should remain.
bakkot
left a comment
bakkot
left a comment
There was a problem hiding this comment.
These seem like they might have false positives, but if you've run it against 262, 402, and Temporal with no false positives it's fine to land and we can go back and relax any annoying ones later.
Not totally sure all of these should be confined to algorithms, though.
|
I ran it against 262, hence tc39/ecma262#3805. Haven't run it against 402 or any other specs yet, but I imagine it will just discover changes we actually want to make. |
2 participants
Disclaimer: I used AI in the process of creating this PR.