feat(improvement): improve(surface:'skills') can optimize a skill document (fixes #483)#484
Merged
Merged
Conversation
…UMENT (fixes #483) The paved skills path was unreachable for real skillOpt: baselineSurfaceFor returned the skills REFS array (file pointers) as the surface, but skillOptProposer patches a skill DOCUMENT's text — so it could never meaningfully edit anything, and skillOpt has zero live runs anywhere. Additive fix mirroring ImproveCodeOptions (#480): opts.skills = { document, writeBack? }. When provided, the baseline surface is the document CONTENT (what skillOpt patches) and a shipped winner is persisted via writeBack (the profile ref points at the caller's file, unchanged). Without opts.skills the refs-array behavior is unchanged (back-compat). Test drives the real loop with a stub skill proposer + a judge that rewards an added rule: asserts the baseline surface is the document, and the shipped winner document is written back. 7/7 improvement tests.
tangletools
previously approved these changes
Jul 7, 2026
tangletools
left a comment
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved drewstone PR — 58e54637
This PR was opened by the trusted drewstone account.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: drewstone_author · 2026-07-07T01:55:51Z
…ace (index links + catalog)
tangletools
approved these changes
Jul 7, 2026
tangletools
left a comment
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved drewstone PR — 4e91e2e2
This PR was opened by the trusted drewstone account.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: drewstone_author · 2026-07-07T02:00:22Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #483. The paved
surface: 'skills'path was unreachable for real skillOpt — its baseline surface was the skills REFS array (file pointers) whileskillOptProposerpatches a skill DOCUMENT's text. So skillOpt has never run live anywhere.Additive fix mirroring
ImproveCodeOptions(#480):opts.skills = { document, writeBack? }. With it, the baseline surface is the document CONTENT and a shipped winner persists viawriteBack(the profile ref is the caller's file, unchanged). Without it, the refs-array behavior is untouched.Test drives the real loop with a stub skill proposer + a rule-rewarding judge; asserts baseline == document and the shipped winner writes back. 7/7 improvement tests, typecheck clean. Unblocks the first-ever skills-surface live proof on the OR benchmark.