feat(benchmarks): rank real memory adapters#54
Merged
Conversation
tangletools
approved these changes
Jul 8, 2026
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved drewstone PR — a008ddcd
This PR was opened by the trusted drewstone account.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: drewstone_author · 2026-07-08T18:05:31Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
runMemoryAdapterBenchmark()to run memory cases through actualAgentMemoryAdapterimplementations and persist a ranking report.createNoopMemoryBenchmarkAdapter()andcreateInMemoryBenchmarkAdapter().Real run
pnpm exec tsx -e ... runMemoryAdapterBenchmark(...)/tmp/agent-knowledge-real-memory-ranking-final/memory-adapter-ranking.jsonin-memoryranked feat(readiness): bridge knowledge index to agent-eval #1 with mean score0.9375and pass rate0.9167over12/12cells;no-memoryranked feat: add source freshness readiness audit #2 with mean score0.25and pass rate0over12/12cells./tmp/agent-knowledge-real-memory-ranking-final/in-memory/first-party_memory-lifecycle_allergy_0/cached-result.jsonshows the in-memory adapter retrieved stale “no food allergies” memory, scoring0.25on that case.Verification
pnpm install --frozen-lockfile --prefer-offlinepnpm exec tsc --noEmitpnpm exec vitest run tests/benchmarks.test.ts— 8 passedpnpm lintgit diff --checkpnpm exec vitest run— 267 passed, 12 skippedpnpm build