Take the engine forty three commits forward - #41
Merged
Merged
Conversation
The pin had not moved since 230581c and main is at 9dcb7b4, which is forty three commits and about a month of engine work. Two of them are why this is worth doing rather than tidy: a92d9c1 lays a column of equal length byte rows out end to end and 5aee3d5 builds a string vector straight from the bytes it decoded to, so BYTES is a type the engine has values for and the tests in this repository that read one stop being tests written ahead of the engine. Nothing in the binding changed. The pin is three lines in Cargo.toml and the lock lines that follow from them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pin had not moved since
230581cand engine main is at9dcb7b4, which is forty three commits behind. This moves it.Two of the commits in that range are why this is worth doing rather than tidy.
a92d9c1lays a column of equal length byte rows out end to end and5aee3d5builds a string vector straight from the bytes it decoded to, so BYTES is now a type the engine has values for. The tests in this repository that read one were written ahead of the engine and fail against the old pin withnothing may follow RETURN, found string literal. They should pass here.Nothing in the binding changed. The diff is three revisions in Cargo.toml and the lock lines that follow from them.
Part of DX4 (tamnd/zu#170), whose second box asks for the differential suite green across all five clients, which cannot be read while three of the five are pinned to different engines.