Build on Rust 1.98 - #36
Merged
Merged
Conversation
tamnd/zu moved to 1.98.0 and toolchains.toml is what says which version every repository holds, so this follows it: the toolchain file, the manifest floor, and the two maturin jobs that name the version themselves because the build container does not read the toolchain file. Nothing in the source needed changing. The 1.98 lint that caught the other repositories, chunks_exact_to_as_chunks, has nothing to fire on here. cargo check, fmt and clippy with -D warnings are clean on 1.98 for the default features and for both of the feature rows CI builds, and pytest is 780 passed, 5 skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35.
tamnd/zu is on 1.98.0 as of tamnd/zu#516, and
toolchains.tomlthereis the one table that says which version every repository holds, so
this repository follows it. Four places name a version:
rust-toolchain.toml, which is what a local build readsrust-versioninCargo.toml, the floorwheels.ymlandinstall.yml, which name theversion themselves because the manylinux and musllinux containers do
not read the toolchain file
No source change was needed.
chunks_exact_to_as_chunks, the new 1.98lint that broke tamnd/zu and tamnd/zu-node, has nothing to fire on
here.
Checked locally on 1.98.0:
cargo check --all-targets,cargo fmt --all --check, andcargo clippy --all-targets -- -D warningsclean--no-default-features --features pyo3/extension-moduleand--features abi3t,pyo3/extension-modulepytest: 780 passed, 5 skipped